-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The dev container .gitignore file is confusing #135
Comments
StevenMaude
added a commit
that referenced
this issue
Jun 18, 2024
This change removes the need for a researcher to manually copy in the additional `.devcontainer/.gitignore`, when adding the Codespaces configuration to an existing repository. This step can be tricky as mentioned in #135.
StevenMaude
added a commit
to opensafely/documentation
that referenced
this issue
Jun 18, 2024
See opensafely/research-template#135. This requires opensafely/research-template#136 to be merged.
Note: a troubleshooting guide hasn't been yet added, so cannot be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we've been getting user feedback for Codespaces, and our updated dev container configuration, we've found on two or three occasions that researchers have had difficulty with their .gitignore file.
We're currently asking people to manually copy the files in the .devcontainer directory from opensafely/research-template to their repo. However, when downloading dotfiles, GitHub removes the leading "." and on some platforms/browsers appends ".txt" (Windows/Edge). We've added some instructions for researchers to follow to correct this, but we believe there's still the potential for confusion.
An easier solution might be for us to move the contents of the .devcontainers/.gitignore into the root .gitignore and to ask people to update that instead.
We originally added a .gitignore into the .devcontainers directory so that we could keep all dev container related changes in a single location. We thought this would make scripting updates easier and mean that the Codespaces configuration isn't affecting the rest of the code base. However, that seems to have come with an unexpected overhead for manually copying things.
Acceptance criteria:
The text was updated successfully, but these errors were encountered: