refactor: use custom element constructors instead of tag names #354
Conversation
|
@ca-d I would suggest doing the rearrangement of all import statements at the end of this refactor. There are just too many inconsistencies at the moment and makes it harder to review if done right now. |
Sounds good. |
Co-authored-by: Sai Mounika Manduri <[email protected]>
…m elements (#370) Co-authored-by: Sai Mounika Manduri <[email protected]>
JakobVogelsang
force-pushed
the
refactor-html-references
branch
from
12739c8
to
624b78d
Compare
refactor(all-files): changing the html references
ca-d
changed the title
* refactor: scope editor-container * refactor: scope zeroline-pane * refactor: scope ied-editor
* refactor(all-files): change the mwc-dialog tags to Dialog class * refactor: declare Dailog class based on DailogBase * test: update snapshots Co-authored-by: Sai Mounika Manduri <[email protected]>
Co-authored-by: Sai Mounika Manduri <[email protected]>
…ur-color (#380) * refactor(all-files): change the mwc-select, mwc-checkbox to class names * fix(foundation): precise checkValidity Co-authored-by: Sai Mounika Manduri <[email protected]>
…#381) Co-authored-by: Sai Mounika Manduri <[email protected]>
…oggle (#382) * refactor: scope custom element mwc-icon-button * refactor: scope costom element mwc-icon-button-toggle
* refactor: scope custom elements mwc-icon * refactor: scope custom element mwc-menu * refactor: scope custom element mwc-switch
|
Sadly, we only noticed with the second to last component migrated (tab) that there are hard internal dependencies between mwc-tab and mwc-tab-bar which forbid us from registering our own tag names for mwc elements at the moment. We may think about raising an issue with the material-web team about future support for Scoped Custom Element Registry . Thank you for your painstaking work @mandurisaimounika , your changelog was invaluable for us in preparing #395 . |
Closes #350