Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loop #6

Closed
sepandhaghighi opened this issue Jun 1, 2023 · 0 comments · Fixed by #42
Closed

Support loop #6

sepandhaghighi opened this issue Jun 1, 2023 · 0 comments · Fixed by #42
Assignees
@sepandhaghighi @sadrasabouri
Labels
enhancement New feature or request new feature
Milestone
nava v0.5

Comments

@sepandhaghighi
Copy link
Member

Description

Support loop
@sepandhaghighi sepandhaghighi added enhancement New feature or request new feature labels Jun 1, 2023
@sepandhaghighi sepandhaghighi added this to the nava v0.2 milestone Jun 1, 2023
@sepandhaghighi sepandhaghighi removed this from the nava v0.2 milestone Jun 10, 2023
@sadrasabouri sadrasabouri self-assigned this Jun 17, 2023
@sadrasabouri sadrasabouri added this to the nava v0.3 milestone Jan 18, 2024
sadrasabouri added a commit that referenced this issue Jan 21, 2024
@sadrasabouri
log : changes logged. (#6)
5b8e06c
@sadrasabouri sadrasabouri mentioned this issue Jan 21, 2024
Merged
@sadrasabouri sadrasabouri removed this from the nava v0.3 milestone Jan 21, 2024
sepandhaghighi added a commit that referenced this issue Mar 29, 2024
@sadrasabouri @sepandhaghighi
Loop (#31)
ec72563 
* update : make `__play_win_flags` more understandable.

* add : `loop` adde to `__play_win` function.

* add : `loop` added to `__play_linux` function.

* add : `loop` added to `__play_proc_linux` function.

* add : `loop` added to `__play_mac` function.

* add : `loop` parameter added to `__play_proc_mac` function.

* add : `loop` added to `play` function.

* add : `SOUND_KEYBOARD_INTERRUPT_ERROR`.

* log : changes logged. (#6)

* update : `README.md` updated.

* add : `# pragma: no cover` to keyboad exceptions.

* test : tests added.

* fix : merge conflict error fixed.

* revert : changes reverted.

* revert : revert completed.

* fix : some loop removed

* fix : loop added play_linux sync mode

* fix : loop added play_mac sync mode

* fix : loop added to NavaThread

* fix : minor bug in loop section fixed

* fix : manual_test.py script updated

* fix : minor bug in nava thread fixed

* fix : loop flag bug in windows fixed

* fix : minor edit in tests

* fix : minor edit in thread stop method

* fix : minor edit in thread stop method

* fix : minor edit in thread stop method

* fix : minor bug in loop exit fixed

* fix : manual_test.py script updated

* fix : LOOP_ASYNC_ERROR error message added

* fix : error_test.py updated

* fix : function_test.py updated

* fix : minor bug in tests fixed

* fix : minor bug in tests fixed

* fix : autopep8

* update : `loop` and `async` replaced in `README.md`.

* update : `READEME.md` updated with comments and usecase of `loop` and `async_mode` in same time.

* edit : `loop` moved to `NavaThread.__init__`.

* fix : typo fixed.

* fix : minor edit in nava thread exception

* fix : LOOP_ASYNC_ERROR updated

* fix : error_test.py updated

---------

Co-authored-by: sepandhaghighi <[email protected]>
@sepandhaghighi sepandhaghighi added this to the nava v0.5 milestone Mar 29, 2024
@sadrasabouri sadrasabouri mentioned this issue Mar 31, 2024
Merged
@sepandhaghighi sepandhaghighi linked a pull request Apr 1, 2024 that will close this issue
Version 0.5 #42
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sepandhaghighi sepandhaghighi

@sadrasabouri sadrasabouri

Labels
enhancement New feature or request new feature
Projects
None yet
Milestone
nava v0.5
Development

Successfully merging a pull request may close this issue.

Version 0.5 openscilab/nava
2 participants
@sepandhaghighi @sadrasabouri