Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bump pandas to the latest version #223

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: Bump pandas to the latest version #223

merged 1 commit into from
Apr 3, 2023

Conversation

lewisjared
Copy link
Collaborator

@lewisjared lewisjared commented Apr 1, 2023 •
edited
Loading

Pull request

Bump pandas and update tests to handle the latest version of pandas. This also allows the use of newer versions of Python during CI. This MR removes running the tests on Python v3.8 and adds Python v3.11.

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added
  • feat: Add uniform year interpolation #221 to fix the notebooks

Closes #203 #219

@codecov
Copy link

codecov bot commented Apr 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5e94e98) 95.82% compared to head (79a76e2) 95.82%.

❗ Current head 79a76e2 differs from pull request most recent head cb02342. Consider uploading reports for the commit cb02342 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          23       23           
  Lines        2084     2084           
  Branches      370      370           
=======================================
  Hits         1997     1997           
  Misses         69       69           
  Partials       18       18
Impacted Files Coverage Δ
src/scmdata/run.py 95.94% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lewisjared lewisjared self-assigned this Apr 1, 2023
znicholls
znicholls approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully easy to address comments

setup.cfg Outdated
@@ -23,6 +23,8 @@ classifiers =
Programming Language :: Python :: 3.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Programming Language :: Python :: 3.7

Let's drop 3.7 and 3.8 as officially supported if we're not testing them?

setup.cfg Outdated Show resolved Hide resolved
.github/workflows/ci-cd-workflow.yml Outdated
@@ -55,7 +55,7 @@ jobs:
strategy:
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
python-version: [3.7, 3.8, 3.9]
python-version: [3.7, 3.9, 3.11]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: [3.7, 3.9, 3.11]
python-version: [3.9, 3.10, 3.11]

Or why only do every second version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It spanned the supported versions and would take half the testing time

End of support for Python3.7 is in a couple of months https://endoflife.date/python so I'm happy to drop it. I'll add 3.8

setup.cfg
@@ -23,6 +23,8 @@ classifiers =
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say let's either officially drop support, or keep the tests?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping 3.7 and ensuring the tests cover 3.8

setup.cfg Outdated Show resolved Hide resolved
src/scmdata/run.py Show resolved Hide resolved
tests/unit/test_ops.py Show resolved Hide resolved
@lewisjared lewisjared force-pushed the 203-update-pandas branch 3 times, most recently from 49254de to fb53339 Compare April 3, 2023 04:31
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@lewisjared
fix: Bump pandas to the latest version
cb02342 
Bump pandas and update tests to handle the latest version of pandas. This also allows the use of newer versions of Python during CI.

BREAKING CHANGE: Removes support for Python 3.7
@lewisjared lewisjared merged commit 1dfdc36 into master Apr 3, 2023
@lewisjared lewisjared deleted the 203-update-pandas branch April 3, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholls znicholls znicholls approved these changes

Assignees

@lewisjared lewisjared

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to support pandas >= 1.4.3
2 participants
@lewisjared @znicholls