Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Datasource testing connection don't validate endpoints with path #5656

Closed
1 of 2 tasks
xinruiba opened this issue Jan 4, 2024 · 1 comment · Fixed by #5663
Closed
1 of 2 tasks

[BUG] Datasource testing connection don't validate endpoints with path #5656

xinruiba opened this issue Jan 4, 2024 · 1 comment · Fixed by #5663
Assignees
Labels
bug Something isn't working

Comments

@xinruiba
Copy link
Member

xinruiba commented Jan 4, 2024

Task List

Describe the bug

If cx adds endpoint with path appended (for example: https://OpenSearchEndpoint/_dashboards) as a datasource, connection test will pass, but cx can't create index pattern or add sample data;

We may need to validate endpoint's path is empty when testing connection

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Dashboards Management" ---> "Data Sources"
  2. Click on "Create data source connection"
  3. Fill in the form with DataSource Title. eg: "test"
  4. Fill in the form with DataSource Endpoint followed with a path name. eg: "https://OpenSearchEndPoint/_dashboard"
  5. Click on "Test Connection" the test will pass
  6. Go to "Home" ---> "Add Sample Data" ---> "Data Source" choose Test --->
  7. Error shows up: sample data not able to be added
Screenshot 2023-11-30 at 8 17 39 PM

Expected behavior
DataSource should not be able to created with an endpoint appended with a path.
We should do URL validation to make sure not path name appended to a datasource endpoint.

OpenSearch Version
2.11

Dashboards Version
2.11

Plugins

Please list all plugins currently enabled.
N/A

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: Linux
  • Browser and version: Chrome Version 120.0.6099.129

Additional context

Add any other context about the problem here.

@xinruiba xinruiba added bug Something isn't working untriaged labels Jan 4, 2024
@xinruiba
Copy link
Member Author

xinruiba commented Jan 4, 2024

I have a proposal to fix this issue. Creating a PR now.

xinruiba added a commit to xinruiba/OpenSearch-Dashboards that referenced this issue Jan 5, 2024
@kavilla kavilla removed the untriaged label Jan 5, 2024
Flyingliuhub pushed a commit that referenced this issue Jan 23, 2024
…5663)

* fix Datasource testing connection don't validate endpoints with path #5656
Signed-off-by: Xinrui Bai <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 23, 2024
…5663)

* fix Datasource testing connection don't validate endpoints with path #5656
Signed-off-by: Xinrui Bai <[email protected]>
(cherry picked from commit b5d39b6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Flyingliuhub pushed a commit that referenced this issue Jan 25, 2024
…5663) (#5727)

* fix Datasource testing connection don't validate endpoints with path #5656
Signed-off-by: Xinrui Bai <[email protected]>
(cherry picked from commit b5d39b6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma pushed a commit to yujin-emma/OpenSearch-Dashboards that referenced this issue Feb 5, 2024
…pensearch-project#5663)

* fix Datasource testing connection don't validate endpoints with path opensearch-project#5656
Signed-off-by: Xinrui Bai <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants