-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Datasource testing connection don't validate endpoints with path #5656
Labels
bug
Something isn't working
Comments
I have a proposal to fix this issue. Creating a PR now. |
xinruiba
added a commit
to xinruiba/OpenSearch-Dashboards
that referenced
this issue
Jan 5, 2024
…pensearch-project#5656 Signed-off-by: Xinrui Bai <[email protected]>
9 tasks
Flyingliuhub
pushed a commit
that referenced
this issue
Jan 23, 2024
…5663) * fix Datasource testing connection don't validate endpoints with path #5656 Signed-off-by: Xinrui Bai <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Jan 23, 2024
…5663) * fix Datasource testing connection don't validate endpoints with path #5656 Signed-off-by: Xinrui Bai <[email protected]> (cherry picked from commit b5d39b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Flyingliuhub
pushed a commit
that referenced
this issue
Jan 25, 2024
…5663) (#5727) * fix Datasource testing connection don't validate endpoints with path #5656 Signed-off-by: Xinrui Bai <[email protected]> (cherry picked from commit b5d39b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this issue
Feb 5, 2024
…pensearch-project#5663) * fix Datasource testing connection don't validate endpoints with path opensearch-project#5656 Signed-off-by: Xinrui Bai <[email protected]> Signed-off-by: yujin-emma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Task List
Describe the bug
If cx adds endpoint with path appended (for example:
https://OpenSearchEndpoint/_dashboards
) as a datasource, connection test will pass, but cx can't create index pattern or add sample data;We may need to validate endpoint's path is empty when testing connection
To Reproduce
Steps to reproduce the behavior:
Expected behavior
DataSource should not be able to created with an endpoint appended with a path.
We should do URL validation to make sure not path name appended to a datasource endpoint.
OpenSearch Version
2.11
Dashboards Version
2.11
Plugins
Please list all plugins currently enabled.
N/A
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: