[Rename] telemetry #109
Merged
[Rename] telemetry #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boktorbb
suggested changes
Mar 11, 2021
| @@ -2426,10 +2426,10 @@ | |||
| }, | |||
| "ess": { | |||
| "properties": { | |||
| "kb_uuid": { | |||
| "opensearch_dashboards_uuid": { | |||
There was a problem hiding this comment.
since this is an abbreviation, we should probably make this osd_uuid
| @@ -33,14 +33,14 @@ const licenseSchema: MakeSchemaFrom<LicenseUsage> = { | |||
|
|
|||
| export const staticTelemetrySchema: MakeSchemaFrom<StaticTelemetryUsage> = { | |||
| ece: { | |||
| kb_uuid: { type: 'keyword' }, | |||
| es_uuid: { type: 'keyword' }, | |||
| opensearch_dashboards_uuid: { type: 'keyword' }, | |||
There was a problem hiding this comment.
It can be either, just have no strong preference knowing we may not eve use it.
There was a problem hiding this comment.
Yeah are we ripping it out? Might be easier. Since now that I notice it is says ece and ess which I assume mean elastic cloud enterprise and elasticsearch service
There was a problem hiding this comment.
in a meeting we discussed we will leave ece and ess for now.
| account_id: { type: 'keyword' }, | ||
| license: licenseSchema, | ||
| }, | ||
| ess: { | ||
| kb_uuid: { type: 'keyword' }, | ||
| es_uuid: { type: 'keyword' }, | ||
| opensearch_dashboards_uuid: { type: 'keyword' }, |
| @@ -95,14 +95,14 @@ export interface LicenseUsage { | |||
|
|
|||
| export interface StaticTelemetryUsage { | |||
| ece?: { | |||
| kb_uuid: string; | |||
| es_uuid: string; | |||
| opensearch_dashboards_uuid: string; | |||
| account_id: string; | ||
| license: LicenseUsage; | ||
| }; | ||
| ess?: { | ||
| kb_uuid: string; | ||
| es_uuid: string; | ||
| opensearch_dashboards_uuid: string; |
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
rename-telemetry
branch
from
1f5c9c8
to
066a02b
Compare
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Kawika Avilla <[email protected]>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Kawika Avilla <[email protected]>
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Aug 29, 2023
…opensearch-project#109) * update snapshot for collapsible_nav.test.tsx and header.test.tsx Signed-off-by: yuye-aws <[email protected]> * fix test error Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
…opensearch-project#109) * update snapshot for collapsible_nav.test.tsx and header.test.tsx Signed-off-by: yuye-aws <[email protected]> * fix test error Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
…opensearch-project#109) * update snapshot for collapsible_nav.test.tsx and header.test.tsx Signed-off-by: yuye-aws <[email protected]> * fix test error Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#37
Description of changes:
Rename files and variables within plugins/telemetry
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.