[BWC] Updates to BWC tests

[kavilla]

Description

Allows the calling script with file location or url to enable
the CI/CD pipeline to pass URLs.

Some minor clean ups related to linter and pass by CSV for params.

Finally, update to add releases parameter which enables us to test
version mismatch if/when we allow the out of the box experience of
OpenSearch Dashboards to work with previous versions of OpenSearch.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

n/a

Check List

• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[ananzh]

LGTM, except some minor details..
Pls help me to understand. Thx. ❤️‍🔥

[ananzh]

if we bring these two DEFAULT values, it definitely help users to run the script. but it would also need to be updated every version, right? so should we just let user to specify the os and osd location?

[kavilla]

Good catch! They can still do that for using yarn test:bwc and passing the correct params. Right now people aren't pointed to run this script so ideally everything in this script is in a work in progress state.

This should be temp so it is setup to play with the CI/CD better. Ideally, this value on main will be set with the results from this opensearch-project/opensearch-build#1492 so that it is always using the latest distribution of OpenSearch and we can pull the version of package.json to get the current value. Then when a release branch is cut we can just modify this so it only takes the release url something like https://artifacts.opensearch.org/releases/bundle/opensearch/$VERSION/opensearch-$VERSION-linux-x64.tar.gz.

[ananzh]

why do we need to remove the config file? thx

[kavilla]

Right now by default OpenSearch Dashboards distributions come bundled with https://github.com/opensearch-project/opensearch-build/blob/main/config/opensearch_dashboards.yml. So it just ensures it doesn't have that security plugin configurations in the yaml file.

One gotcha here, is that it assumes that you are inputting a distribution/non-distribution that you didn't configure locally.

However, that can be logged as an improvement. With that said, is this ok?

[tmarkley]

Looks great, thanks Rocky!

[kavilla]

@ananzh, @tmarkley apologies, repushed because latest is now available for distributions. For example,

https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/latest/linux/x64/dist/opensearch/opensearch-1.3.0-linux-x64.tar.gz

[opensearch-trigger-bot]

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1190-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6960f9c5385f456ccb66ce236798088496e7c46a
# Push it to GitHub
git push --set-upstream origin backport/backport-1190-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1190-to-1.x.