Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Fix display issue #179

Closed
wants to merge 1 commit into from
Closed

[Rename] Fix display issue #179

wants to merge 1 commit into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 17, 2021

Find a minor renaming error in src/core/utils/default_app_categories.ts which will cause navLinks returns undefined category in src/plugins/opensearch_dashboards_overview/publid/plugin.ts

@odfe-release-bot
Copy link

❌   DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/dashboards ea048182a02059d8be73a6f48e111dce8e63225b to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@mihirsoni mihirsoni changed the title Fix display issue. [Rename] Fix display issue Mar 17, 2021
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign the commit @ananzh

@ananzh
Copy link
Member Author

ananzh commented Mar 18, 2021

Miss Signed off. Have sent a new PR.

@ananzh ananzh closed this Mar 18, 2021
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Sep 19, 2023
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 20, 2023
* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <[email protected]>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <[email protected]>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <[email protected]>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <[email protected]>

* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* rename variable and function name

Signed-off-by: yuye-aws <[email protected]>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Mar 21, 2024
* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <[email protected]>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <[email protected]>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <[email protected]>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <[email protected]>

* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* rename variable and function name

Signed-off-by: yuye-aws <[email protected]>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
# Conflicts:
#	src/core/public/workspace/workspaces_service.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Apr 16, 2024
* Add copy saved objects among workspaces functionality (opensearch-project#53)

* Add copy saved objects among workspaces functionality

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>

* Fix bug

Signed-off-by: gaobinlong <[email protected]>

* Fix bug

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
# Conflicts:
#	src/core/server/saved_objects/routes/copy.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate selected objects (opensearch-project#113)

* fix typo

Signed-off-by: yuye-aws <[email protected]>

* adjust copy modal

Signed-off-by: yuye-aws <[email protected]>

* list workspace with write permission on copy modal

Signed-off-by: yuye-aws <[email protected]>

* add copy icon and move getcopyworkspaces function from copy_modal to saved_object table

Signed-off-by: yuye-aws <[email protected]>

* fix duplicate error in public workspace and change copy to duplicate all in header

Signed-off-by: yuye-aws <[email protected]>

* bug fix: create saved objects in public workspace

Signed-off-by: yuye-aws <[email protected]>

* update snapshots

Signed-off-by: yuye-aws <[email protected]>

* remove unused import

Signed-off-by: yuye-aws <[email protected]>

* change validate schema

Signed-off-by: yuye-aws <[email protected]>

* behavior subject bug fix for workspace plugin

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
# Conflicts:
#	src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap
#	src/core/server/saved_objects/permission_control/acl.test.ts
#	src/core/server/saved_objects/permission_control/client.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/workspace/server/plugin.ts
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
# Conflicts:
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/header.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate all and single objects (opensearch-project#121)

* implement all duplicate copy modal

Signed-off-by: yuye-aws <[email protected]>

* add spacer after checkbox list

Signed-off-by: yuye-aws <[email protected]>

* add fail message for copy saved objects

Signed-off-by: yuye-aws <[email protected]>

* change title wording to manage library

Signed-off-by: yuye-aws <[email protected]>

* single duplicate

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* remove comment

Signed-off-by: yuye-aws <[email protected]>

* bug fix: keep selected saved objects info when cancel duplicate all

Signed-off-by: yuye-aws <[email protected]>

* fix typo

Signed-off-by: yuye-aws <[email protected]>

* use icu syntax in copy message

Signed-off-by: yuye-aws <[email protected]>

* bug fix: keep selected saved objects info when cancel duplicate single

Signed-off-by: yuye-aws <[email protected]>

* set current workspace as the first option

Signed-off-by: yuye-aws <[email protected]>

* update snapshot

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update snapshot

Signed-off-by: yuye-aws <[email protected]>

* bug fix for saved object table

Signed-off-by: yuye-aws <[email protected]>

* update snapshot

Signed-off-by: yuye-aws <[email protected]>

* remove unused file

Signed-off-by: yuye-aws <[email protected]>

* change i18n constant

Signed-off-by: yuye-aws <[email protected]>

* remove empty push

Signed-off-by: yuye-aws <[email protected]>

* hide duplicate when workspace is disabled

Signed-off-by: yuye-aws <[email protected]>

* update snapshots

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
# Conflicts:
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/saved_objects_management/public/plugin.ts

* feat: Duplicate dashboard visualize (opensearch-project#148)

* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <[email protected]>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <[email protected]>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <[email protected]>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <[email protected]>

* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* rename variable and function name

Signed-off-by: yuye-aws <[email protected]>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
# Conflicts:
#	src/core/public/workspace/workspaces_service.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* delete useless code

* refactor dupicate_model code and fix test error

* add duplicate all/selected saved objects unit test

* add util and copy unit test

Signed-off-by: yubonluo <[email protected]>

* fix bug

Signed-off-by: yubonluo <[email protected]>

* fix unit test error

Signed-off-by: yubonluo <[email protected]>

* add all unit test and fix code error

Signed-off-by: yubonluo <[email protected]>

* revert useless modifications

Signed-off-by: yubonluo <[email protected]>

* add snapshot code

Signed-off-by: yubonluo <[email protected]>

* delete useless code

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* split duplicate_modal

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* fix unit test

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <[email protected]>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* delete useless code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024
* Add copy saved objects among workspaces functionality (opensearch-project#53)

* Add copy saved objects among workspaces functionality

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>

* Fix bug

Signed-off-by: gaobinlong <[email protected]>

* Fix bug

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
# Conflicts:
#	src/core/server/saved_objects/routes/copy.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate selected objects (opensearch-project#113)

* fix typo

Signed-off-by: yuye-aws <[email protected]>

* adjust copy modal

Signed-off-by: yuye-aws <[email protected]>

* list workspace with write permission on copy modal

Signed-off-by: yuye-aws <[email protected]>

* add copy icon and move getcopyworkspaces function from copy_modal to saved_object table

Signed-off-by: yuye-aws <[email protected]>

* fix duplicate error in public workspace and change copy to duplicate all in header

Signed-off-by: yuye-aws <[email protected]>

* bug fix: create saved objects in public workspace

Signed-off-by: yuye-aws <[email protected]>

* update snapshots

Signed-off-by: yuye-aws <[email protected]>

* remove unused import

Signed-off-by: yuye-aws <[email protected]>

* change validate schema

Signed-off-by: yuye-aws <[email protected]>

* behavior subject bug fix for workspace plugin

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
# Conflicts:
#	src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap
#	src/core/server/saved_objects/permission_control/acl.test.ts
#	src/core/server/saved_objects/permission_control/client.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/workspace/server/plugin.ts
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
# Conflicts:
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/header.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate all and single objects (opensearch-project#121)

* implement all duplicate copy modal

Signed-off-by: yuye-aws <[email protected]>

* add spacer after checkbox list

Signed-off-by: yuye-aws <[email protected]>

* add fail message for copy saved objects

Signed-off-by: yuye-aws <[email protected]>

* change title wording to manage library

Signed-off-by: yuye-aws <[email protected]>

* single duplicate

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* remove comment

Signed-off-by: yuye-aws <[email protected]>

* bug fix: keep selected saved objects info when cancel duplicate all

Signed-off-by: yuye-aws <[email protected]>

* fix typo

Signed-off-by: yuye-aws <[email protected]>

* use icu syntax in copy message

Signed-off-by: yuye-aws <[email protected]>

* bug fix: keep selected saved objects info when cancel duplicate single

Signed-off-by: yuye-aws <[email protected]>

* set current workspace as the first option

Signed-off-by: yuye-aws <[email protected]>

* update snapshot

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update snapshot

Signed-off-by: yuye-aws <[email protected]>

* bug fix for saved object table

Signed-off-by: yuye-aws <[email protected]>

* update snapshot

Signed-off-by: yuye-aws <[email protected]>

* remove unused file

Signed-off-by: yuye-aws <[email protected]>

* change i18n constant

Signed-off-by: yuye-aws <[email protected]>

* remove empty push

Signed-off-by: yuye-aws <[email protected]>

* hide duplicate when workspace is disabled

Signed-off-by: yuye-aws <[email protected]>

* update snapshots

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
# Conflicts:
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/saved_objects_management/public/plugin.ts

* feat: Duplicate dashboard visualize (opensearch-project#148)

* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <[email protected]>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <[email protected]>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <[email protected]>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <[email protected]>

* rename copy to duplicate

Signed-off-by: yuye-aws <[email protected]>

* duplicate in visualization

Signed-off-by: yuye-aws <[email protected]>

* duplicate in dashboard

Signed-off-by: yuye-aws <[email protected]>

* resolve conflict

Signed-off-by: yuye-aws <[email protected]>

* update test and snapshots

Signed-off-by: yuye-aws <[email protected]>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <[email protected]>

* remove clone for dashboard

Signed-off-by: yuye-aws <[email protected]>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <[email protected]>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <[email protected]>

* change wording

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <[email protected]>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <[email protected]>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <[email protected]>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <[email protected]>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <[email protected]>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <[email protected]>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <[email protected]>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <[email protected]>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <[email protected]>

* merge commits

Signed-off-by: yuye-aws <[email protected]>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <[email protected]>

* remote create vis reference logic

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <[email protected]>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <[email protected]>

* change type definition logic

Signed-off-by: yuye-aws <[email protected]>

* rename variable and function name

Signed-off-by: yuye-aws <[email protected]>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
# Conflicts:
#	src/core/public/workspace/workspaces_service.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* delete useless code

* refactor dupicate_model code and fix test error

* add duplicate all/selected saved objects unit test

* add util and copy unit test

Signed-off-by: yubonluo <[email protected]>

* fix bug

Signed-off-by: yubonluo <[email protected]>

* fix unit test error

Signed-off-by: yubonluo <[email protected]>

* add all unit test and fix code error

Signed-off-by: yubonluo <[email protected]>

* revert useless modifications

Signed-off-by: yubonluo <[email protected]>

* add snapshot code

Signed-off-by: yubonluo <[email protected]>

* delete useless code

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* split duplicate_modal

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* fix unit test

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <[email protected]>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* delete useless code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants