Bump moment-timezone from 0.5.34 to 0.5.35

[dependabot]

Bumps moment-timezone from 0.5.34 to 0.5.35.

Changelog

Sourced from moment-timezone's changelog.

0.5.35 2022-08-23

• Fix command injection in data pipeline GHSA-56x4-j7p9-fcf9
• Fix cleartext transmission of sensitive information GHSA-v78c-4p63-2j6c

Thanks to the OpenSSF Alpha-Omega project for reporting these!

Commits

• b8fb1ba Build moment-timezone 0.5.35
• f1b5e5a Add changelog for 0.5.35
• 8b0eb0c Bump version to 0.5.35
• 7915ac5 Bugfix: Prevent cleartext transmission of tz data during build
• ce955a3 Bugfix: Fix command injection vulnerability in grunt tzdata pipeline
• 9430b4c Merge remote-tracking branch 'origin/master' into develop
• feaf900 Updated contributing.md + added 2021e files
• 704cfac updated contributing.md
• 877c863 Updated contributing.md + added 2021e files
• 5a3015c updated contributing.md
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

[codecov-commenter]

Codecov Report

Merging #2229 (c841a5a) into main (140c56f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
+ Coverage   66.77%   66.78%   +0.01%     
==========================================
  Files        3133     3133              
  Lines       60079    60079              
  Branches     9152     9152              
==========================================
+ Hits        40117    40125       +8     
+ Misses      17771    17765       -6     
+ Partials     2191     2189       -2     

Impacted Files	Coverage Δ
...ic/application/models/sense_editor/sense_editor.ts	64.88% <0.00%> (+0.88%)	⬆️
...ared/static/forms/hook_form_lib/hooks/use_field.ts	66.66% <0.00%> (+0.96%)	⬆️
packages/osd-optimizer/src/node/cache.ts	52.77% <0.00%> (+2.77%)	⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	87.75% <0.00%> (+4.08%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[noCharger]

Dashboard oncall checked-in:

Related high priority security vulnerability issues -
#2262
#2263

[joshuarrrr]

I'm a little concerned we might run into moment/moment-timezone#858, because we do declare a dependency on "@types/moment-timezone": "^0.5.12",. I'm inclined to trust the passing tests, but it would be useful if we can verify that we don't need to remove that dependency, too.

[ashwin-pc]

@joshuarrrr that issue is present since 0.5.30 and we have already been using 0.5.34 in the repo for a while now. I dont think patch version 35 will introduce any new issue because of that.

[joshuarrrr]

Oh, so we had bumped the yarn.lock version while leaving the package.json dependency at 0.5.27? Why did we do that? Did we not trust the package semver?

[kavilla]

Oh, so we had bumped the yarn.lock version while leaving the package.json dependency at 0.5.27? Why did we do that? Did we not trust the package semver?

Just in general we usually do that so we can backport it to older branches and not worry about the silly conditional check that does only a string compare to plugins dependencies even though semver wise they are the same exact version.

[ashwin-pc]

So let me do this:

1. Create a PR that only updates the yarn.lock once again for this change
2. Create an issue to remove the semver check for patch versions so that we dont need to be afraid of patch versions being merged in like this

[kavilla]

Closing in favor of this PR that ensures we don't prevent plugins from building.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.