[Tests] Updates for integration tests (#208) #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated automated snapshots by running yarn test:jest_integration -u However there is a snapshot being updated to an old logo so I'm trying to find out where that is being generated. Fixed some broken test cases due to incorrect imports or newlines. Signed-off-by: Kawika Avilla <[email protected]>
Noticed these scripts were unchanged so I updated them. Signed-off-by: Kawika Avilla <[email protected]>
Missed references to elastic. Signed-off-by: Kawika Avilla <[email protected]>
These tests try to download snapshots that are no longer valid. Ignoring and adding the [RENAMEME] when we have a valid URL to download snapshots from. Signed-off-by: Kawika Avilla <[email protected]>
Key for a response body was incorrect. Signed-off-by: Kawika Avilla <[email protected]>
Update to use a more generic spinner for app routing because the previous spinner would use logoElastic. Therefore when updating the snapshot would have logoElastic. Signed-off-by: Kawika Avilla <[email protected]>
3 tasks
|
✅ DCO Check Passed 16fc2ea |
mihirsoni
reviewed
Apr 1, 2021
...erver/ui_settings/create_or_upgrade_saved_config/integration_tests/create_or_upgrade.test.ts
Show resolved
Hide resolved
mihirsoni
approved these changes
Apr 1, 2021
ananzh
approved these changes
Apr 2, 2021
kavilla
added a commit
that referenced
this pull request
Apr 5, 2021
* [Tests] update integration snapshots (#208) Updated automated snapshots by running yarn test:jest_integration -u However there is a snapshot being updated to an old logo so I'm trying to find out where that is being generated. Fixed some broken test cases due to incorrect imports or newlines. * [Build] renamed scripts in dev/build/tasks Noticed these scripts were unchanged so I updated them. * [Tests] rename comments Missed references to elastic. * [Tests] ignore tests that download snapshots These tests try to download snapshots that are no longer valid. Ignoring and adding the [RENAMEME] when we have a valid URL to download snapshots from. * [Tests] update stats test to expected value Key for a response body was incorrect. * [Tests] update spinner to remove logo Update to use a more generic spinner for app routing because the previous spinner would use logoElastic. Therefore when updating the snapshot would have logoElastic. Signed-off-by: Kawika Avilla <[email protected]>
raintygao
pushed a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Oct 26, 2023
…ect#239) * Add simple string query flags options to find method Signed-off-by: Hailong Cui <[email protected]> * fix osd boostrap Signed-off-by: Hailong Cui <[email protected]> * Add unit test Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Mar 22, 2024
…ect#239) * Add simple string query flags options to find method Signed-off-by: Hailong Cui <[email protected]> * fix osd boostrap Signed-off-by: Hailong Cui <[email protected]> * Add unit test Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated snapshots were required due to renaming and was executed with:
yarn run test:jest_integration -u. Made the appropriate updates for integration tests to pass. This required updating some files to have the correct values, ignoring a test suite that required downloading an OpenSearch snapshot which we do not have a valid URL, and finally I updated an element that would make the snapshot becomelogoElastic.Detailed explanation:
In the file osd-opensearch/src/artifact.js there is a reference to the snapshot URL that was invalid which the tests in
ui_settings/integration_tests/index.test.tsandui_settings/create_or_upgrade_saved_config/integration_tests/create_or_upgrade.test.tsrequired so ignored that test for now.In
src/core/public/application/ui/app_container.tsx, EuiLoadingElastic would actually have the logoElastic and so if you ran the app and update the url to have a non-existent endpoint it will have the Elastic Logo. I picked the spinner but we can talk about if it was the right choice. But after making the update and re-generating the snapshots the logoElastic is no longer there.After the above I was able to run the integration tests and here is the output:
Finally just some missed renames of kibana that can technically be taken out of this PR.
Issues Resolved
#208
Check List
[ ] New functionality has been documented.[ ] New functionality has javadoc added