Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @zhongnansu as maintainer #2590

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

kristenTian
Copy link
Contributor

@kristenTian kristenTian commented Oct 17, 2022

Signed-off-by: Kristen Tian [email protected]

Description

Zhongnan has kindly accepted the invitation, therefore adding @zhongnansu as maintainer.

Zhongnan has a lot of experience in the team with the project and as an external plugin developer which is what a lot of the core maintainers lack insight on, it would be great to get more of his insight on non-MD PRs with his previous experience.

Some of @zhongnansu 's contributions in the past:

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@kristenTian kristenTian requested a review from a team as a code owner October 17, 2022 23:05
Signed-off-by: Kristen Tian <[email protected]>
@ashwin-pc
Copy link
Member

ashwin-pc commented Oct 17, 2022

@kristenTian Thanks for the PR. Can you also add the reason @zhongnansu was added as a maintainer to the PR description for future reference? e.g.opensearch-project/OpenSearch#3231

@kristenTian
Copy link
Contributor Author

@kristenTian Thanks for the PR. Can you also add the reason @zhongnansu was added as a maintainer to the PR description for future reference? e.g.opensearch-project/OpenSearch#3231

Sure thing, thanks for sharing.

@ashwin-pc ashwin-pc merged commit e3e7605 into opensearch-project:main Oct 18, 2022
@zhongnansu
Copy link
Member

Thank you!

vimalMK pushed a commit to vimalMK/OpenSearch-Dashboards that referenced this pull request Oct 20, 2022
Signed-off-by: Kristen Tian <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: vimal k <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
Signed-off-by: Kristen Tian <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants