Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [VizBuilder] Create a new wizard directly on a dashboard (#2384) #2692

Merged

Conversation

abbyhu2000
Copy link
Member

  • Create a new wizard directly on a dashboard

After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard.

Signed-off-by: abbyhu2000 [email protected]

  • hook change to solve browser warning

Signed-off-by: abbyhu2000 [email protected]

  • Move onsave out from getTopNavConfig function and added unit tests

Signed-off-by: abbyhu2000 [email protected]

  • Add changelog

Signed-off-by: abbyhu2000 [email protected]

Signed-off-by: abbyhu2000 [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…project#2384)

* Create a new wizard directly on a dashboard

After selecting a dashboard, create a new wizard directly from the dashboard and have the option to add to that dashboard.

Signed-off-by: abbyhu2000 <[email protected]>

* hook change to solve browser warning

Signed-off-by: abbyhu2000 <[email protected]>

* Move onsave out from getTopNavConfig function and added unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* Add changelog

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
@abbyhu2000 abbyhu2000 marked this pull request as ready for review October 28, 2022 21:07
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner October 28, 2022 21:07
@abbyhu2000 abbyhu2000 changed the title [VizBuilder] Create a new wizard directly on a dashboard (#2384) [Backport 2.x] [VizBuilder] Create a new wizard directly on a dashboard (#2384) Oct 28, 2022
@abbyhu2000 abbyhu2000 added the v2.4.0 'Issues and PRs related to version v2.4.0' label Oct 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2692 (45f783e) into 2.x (8906a03) will increase coverage by 0.04%.
The diff coverage is 72.00%.

@@            Coverage Diff             @@
##              2.x    #2692      +/-   ##
==========================================
+ Coverage   66.76%   66.81%   +0.04%     
==========================================
  Files        3206     3207       +1     
  Lines       61152    61172      +20     
  Branches     9324     9323       -1     
==========================================
+ Hits        40831    40871      +40     
+ Misses      18086    18066      -20     
  Partials     2235     2235              
Impacted Files Coverage Δ
packages/osd-pm/src/utils/projects_tree.ts 96.07% <ø> (ø)
packages/osd-utils/src/path/index.ts 75.00% <ø> (+18.47%) ⬆️
...s/wizard/public/application/components/top_nav.tsx 5.00% <0.00%> (-0.89%) ⬇️
src/plugins/wizard/public/plugin.ts 27.58% <ø> (ø)
...rd/public/application/utils/get_top_nav_config.tsx 66.66% <75.75%> (+62.82%) ⬆️
...c/plugins/wizard/public/application/utils/mocks.ts 100.00% <100.00%> (ø)
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️
src/plugins/expressions/public/mocks.tsx 93.33% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 merged commit 7792e75 into opensearch-project:2.x Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants