Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update PR workflow to update snapshot #279

Merged
merged 3 commits into from
Apr 10, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 10, 2021

Description

This is temporary is should be deep-dived into why
the snapshots are failing from the CI and then in the
future removed the -u flag from the yml file.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

This is temporary is should be deep-dived into why
the snapshots are failing from the CI and then in the
future removed the -u flag from the yml file.

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
@odfe-release-bot
Copy link

✅   DCO Check Passed 04ebec0

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla requested a review from mihirsoni April 10, 2021 00:46
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@odfe-release-bot
Copy link

✅   DCO Check Passed bcbc390

@kavilla kavilla merged commit d15f8ad into opensearch-project:main Apr 10, 2021
@kavilla kavilla deleted the update-pr-check-workflow branch April 27, 2021 20:57
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Mar 12, 2024
…roject#279)

* [Workspace][Feature] Add ACL related functions (opensearch-project#5084)

* [Workspace] Add ACL related functions for workspace (opensearch-project#146)

* [Workspace] Add acl related functions for workspace

Signed-off-by: gaobinlong <[email protected]>

* Minor change

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>

* Modify changelog

Signed-off-by: gaobinlong <[email protected]>

* Add more unit test cases

Signed-off-by: gaobinlong <[email protected]>

* Modify test case

Signed-off-by: gaobinlong <[email protected]>

* Some minor change

Signed-off-by: gaobinlong <[email protected]>

* Add more test cases

Signed-off-by: gaobinlong <[email protected]>

* Optimize some code and the comments of the functions

Signed-off-by: gaobinlong <[email protected]>

* Add more comments for some basic functions

Signed-off-by: gaobinlong <[email protected]>

* Export more interfaces

Signed-off-by: gaobinlong <[email protected]>

* consume permissions in repository

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: consume permissions in serializer

Signed-off-by: SuZhou-Joe <[email protected]>

* Add unit tests for consuming permissions in repository

Signed-off-by: gaobinlong <[email protected]>

* Remove double exclamation

Signed-off-by: gaobinlong <[email protected]>

* Rename some variables

Signed-off-by: gaobinlong <[email protected]>

* Remove duplicated semicolon

Signed-off-by: gaobinlong <[email protected]>

* Add permissions field to the mapping only if the permission control is enabled

Signed-off-by: gaobinlong <[email protected]>

* Fix test failure

Signed-off-by: gaobinlong <[email protected]>

* Add feature flag config to the yml file

Signed-off-by: gaobinlong <[email protected]>

* Make the comment of feature flag more clear

Signed-off-by: gaobinlong <[email protected]>

* Make comment more clear

Signed-off-by: gaobinlong <[email protected]>

* Remove management permission type

Signed-off-by: gaobinlong <[email protected]>

* Fix test failure

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>

* Remove duplicated attribute

Signed-off-by: gaobinlong <[email protected]>

* Enable acl in integration tests for workspace client wrapper

Signed-off-by: gaobinlong <[email protected]>

* Format the code

Signed-off-by: gaobinlong <[email protected]>

* Modify feature flag

Signed-off-by: gaobinlong <[email protected]>

* Modify feature flag to false

Signed-off-by: gaobinlong <[email protected]>

* Modify feature flag to true

Signed-off-by: gaobinlong <[email protected]>

* Enhance the test case

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants