Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Vis Builder] Add an experimental table visualization in vis builder #2791

Closed
wants to merge 1 commit into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Nov 4, 2022

Backport PR:
#2705

In this PR, we hook up an experimental table vis in vis builder. This table vis is a refactor of previous table. It is written in React and DataGrid component.

In this PR, we did two main things:

  • add an experimental table visualization
  • enable it in vis builder

Issue Resolved (hook up table in vis builder):
#2704

The experimental table vis has all the features from current table, including

  • restore table vis in react using a Datagrid component
  • datagrid component does not support splitted grids. For future transfer to OUI Datagrid, we create a tableGroup in visData for splitted grids.
  • restore basic pagenation, sort and format.
  • implement datagrid columns
  • display column title correctly
  • deangular and re-use formatted column
  • convert formatted column to data grid column
  • restore filter in and filter out value functions
  • format table cell to show Date and percent
  • restore showTotal feature: it allows table vis to show total, avg, min, max and count statics on count
  • restore export csv feature to table vis
  • split table in rows and columns

Beside of restoring original features, there are some changes:

  • [IMPROVE] remove repeated column from split tables Currently, when we split table by columns, the split column is shown both in the table title and as a separate column. This is not needed. In this PR, we remove the repeated column in split tables in col.
  • [NEW FEATURE] adjustable table column width In the new table visualization, customer can adjust the column width as needed.

Issue Resolved:
#2212 #2213 #2305 #2379 #2579

Since this is a hookup PR, we remove un-used table vis types and options because they could be defined in vis builder.

We also create follow up issues for some un-resolved PR comments.

Signed-off-by: Anan Zhuang [email protected]

remove unused scss tyle

Signed-off-by: Anan Zhuang [email protected]

remove total func and percentage col

total func and percentage col are two features that we might need to remove or re-invent for future table vis. For hookup purpose, it doesn't make sense to include some features that we would like to remove.

this PR removes total func and percentage col in both table vis and vis builder

Signed-off-by: Anan Zhuang [email protected]

comment out cellActions
currently filter in/out cell doesn't function in vis builder. we will coumment out cell actions for now.

Signed-off-by: Anan Zhuang [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…n vis builder

Backport PR:
opensearch-project#2705

In this PR, we hook up an experimental table vis in vis builder. This
table vis is a refactor of previous table. It is written in React and
DataGrid component.

In this PR, we did two main things:
* add an experimental table visualization
* enable it in vis builder

Issue Resolved (hook up table in vis builder):
opensearch-project#2704

The experimental table vis has all the features from current table, including
* restore table vis in react using a Datagrid component
* datagrid component does not support splitted grids. For future transfer
to OUI Datagrid, we create a tableGroup in visData for splitted grids.
* restore basic pagenation, sort and format.
* implement datagrid columns
* display column title correctly
* deangular and re-use formatted column
* convert formatted column to data grid column
* restore filter in and filter out value functions
* format table cell to show Date and percent
* restore showTotal feature: it allows table vis to show total,
avg, min, max and count statics on count
* restore export csv feature to table vis
* split table in rows and columns

Beside of restoring original features, there are some changes:

* [IMPROVE] remove repeated column from split tables
Currently, when we split table by columns, the split column is shown
both in the table title and as a separate column. This is not needed.
In this PR, we remove the repeated column in split tables in col.
* [NEW FEATURE] adjustable table column width
In the new table visualization, customer can adjust the column width
as needed.

Issue Resolved:
opensearch-project#2212
opensearch-project#2213
opensearch-project#2305
opensearch-project#2379
opensearch-project#2579

Since this is a hookup PR, we remove un-used table vis types and options
because they could be defined in vis builder.

We also create follow up issues for some un-resolved PR comments.

Signed-off-by: Anan Zhuang <[email protected]>

remove unused scss tyle

Signed-off-by: Anan Zhuang <[email protected]>

remove total func and percentage col

total func and percentage col are two features that we might
need to remove or re-invent for future table vis. For hookup
purpose, it doesn't make sense to include some features that
we would like to remove.

this PR removes total func and percentage col in both table
vis and vis builder

Signed-off-by: Anan Zhuang <[email protected]>

comment out cellActions
currently filter in/out cell doesn't function in vis builder.
we will coumment out cell actions for now.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh requested a review from a team as a code owner November 4, 2022 01:57
@ananzh ananzh added backport 2.4 autocut Skip the changelog verification check on backports labels Nov 4, 2022
@ananzh ananzh closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant