Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VisBuilder] [BUG] fix empty workspace animation does not work in firefox #2853

Merged
merged 2 commits into from
Nov 11, 2022
Merged

[VisBuilder] [BUG] fix empty workspace animation does not work in firefox #2853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f1f1b7
fix: fix VisBuilder empty animation does not work in firefox
raintygao Nov 10, 2022
b3b2beb
doc: add changelog for pull request
raintygao Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Multi DataSource] Update default audit log path ([#2793](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2793))
- [Table Visualization] Fix first column sort issue ([#2828](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2828))
- Temporary workaround for task-kill exceptions on Windows when it is passed a pid for a process that is already dead ([#2842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2842))
- [Vis Builder] Fix empty workspace animation does not work in firefox ([#2853](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2853))

### 🚞 Infrastructure

Expand Down
1 change: 1 addition & 0 deletions src/plugins/vis_builder/public/application/components/workspace.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ $keyframe-multiplier: 1 / $animation-multiplier;
animation: vbDragAnimation #{$total-duartion}s ease-in-out infinite forwards;
position: absolute;
top: 34.5%;
width: 50% !important;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/plugins/vis_builder/public/application/components/workspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@ export const Workspace: FC = ({ children }) => {
body={
<>
<p>Drag a field to the configuration panel to generate a visualization.</p>
<span className="vbWorkspace__container">
<div className="vbWorkspace__container">
<EuiIcon className="vbWorkspace__fieldSvg" type={fields_bg} size="original" />
<EuiIcon
className="vbWorkspace__handFieldSvg"
type={hand_field}
size="original"
/>
</span>
</div>
</>
}
/>
Expand Down