[Build] restore kibana index #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restoring the index from .opensearch_dashboards to .kibana and then updated the tests. This is allowable because this is for functional purposes and for clusters/plugins that will migrate to Dashboards. Their index will not require re-indexing for 1.0.0 and won't require migration after further updates. Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added
build
This was
linked to
issues
May 25, 2021
|
✅ DCO Check Passed 234a703 |
5 tasks
ananzh
previously approved these changes
May 25, 2021
This doesn't have impact on the results of tests but to keep consistency in the index name these updates were missed. Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed b249763 |
tmarkley
approved these changes
May 26, 2021
kavilla
added a commit
that referenced
this pull request
May 26, 2021
* [Build] restore kibana index Restoring the index from .opensearch_dashboards to .kibana and then updated the tests. This is allowable because this is for functional purposes and for clusters/plugins that will migrate to Dashboards. Their index will not require re-indexing for 1.0.0 and won't require migration after further updates. Signed-off-by: Kawika Avilla <[email protected]> * [Tests] updates tests for consistency This doesn't have impact on the results of tests but to keep consistency in the index name these updates were missed. Signed-off-by: Kawika Avilla <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restoring the index from .opensearch_dashboards to .kibana and then
updated the tests (unit, integ, and func test all passing). This is allowable
because this is for functional purposes and for clusters/plugins that will
migrate to Dashboards. Their index will not require re-indexing for 1.0.0
and shouldn't require a full migration after further updates.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#325
Partial: #334
Check List