Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enable theme-switching via Advanced Settings to preview the Next theme #4618

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fe41677 from #4475.

#4475)

* Enable theme-switching via Advanced Settings to preview the Next theme

Also:
* Remove the unused "v8 (beta)" theme
* Remove the overrides that locked in the light default theme
* Correct theme version selection logic in the legacy UI renderer
* Use the latest preview of OUI

Signed-off-by: Miki <[email protected]>

* Enhance ComboBox handling in functional tests

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
(cherry picked from commit fe41677)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #4618 (bac2a3d) into 2.x (57d7ce8) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##              2.x    #4618      +/-   ##
==========================================
- Coverage   66.19%   66.19%   -0.01%     
==========================================
  Files        3315     3315              
  Lines       63892    63892              
  Branches     9969     9969              
==========================================
- Hits        42295    42293       -2     
- Misses      19156    19160       +4     
+ Partials     2441     2439       -2     
Flag Coverage Δ
Linux_1 34.76% <33.33%> (+0.01%) ⬆️
Linux_2 55.07% <50.00%> (ø)
Linux_3 43.22% <0.00%> (-0.01%) ⬇️
Linux_4 35.09% <33.33%> (ø)
Windows_1 34.82% <33.33%> (ø)
Windows_2 55.03% <50.00%> (ø)
Windows_3 43.22% <0.00%> (-0.01%) ⬇️
Windows_4 35.09% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/server/ui_settings/settings/theme.ts 100.00% <ø> (ø)
src/core/server/ui_settings/ui_settings_config.ts 100.00% <ø> (ø)
src/legacy/ui/ui_render/ui_render_mixin.js 0.00% <0.00%> (ø)
packages/osd-optimizer/src/common/theme_tags.ts 86.36% <100.00%> (ø)

... and 3 files with indirect coverage changes

@AMoo-Miki
Copy link
Collaborator

@joshuarrrr joshuarrrr merged commit d8c4cd3 into 2.x Jul 26, 2023
68 of 71 checks passed
@joshuarrrr joshuarrrr deleted the backport/backport-4475-to-2.x branch July 26, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants