Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSCI] Remove ftr test from PR template #5217

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

Leo7Deng
Copy link
Contributor

@Leo7Deng Leo7Deng commented Oct 4, 2023

Description

Removed ftr test step from PR template

Issues Resolved

fixes #5210

Screenshot

Screen Shot 2023-10-04 at 1 41 52 PM

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

joshuarrrr
joshuarrrr previously approved these changes Oct 4, 2023
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small corrections of the changelog, otherwise looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Leo Deng <[email protected]>
@ananzh
Copy link
Member

ananzh commented Oct 5, 2023

@AMoo-Miki @joshuarrrr should this be tagged v2.11.0?

@ananzh ananzh added the v3.0.0 label Oct 5, 2023
@joshuarrrr joshuarrrr merged commit 6268794 into opensearch-project:main Oct 5, 2023
12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
* removed ftr test step from PR template

Signed-off-by: Leo Deng <[email protected]>

* change changelog

Signed-off-by: Leo Deng <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Leo Deng <[email protected]>

---------

Signed-off-by: Leo Deng <[email protected]>
Signed-off-by: Leo Deng <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 6268794)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
willie-hung pushed a commit to willie-hung/OpenSearch-Dashboards that referenced this pull request Oct 5, 2023
* removed ftr test step from PR template

Signed-off-by: Leo Deng <[email protected]>

* change changelog

Signed-off-by: Leo Deng <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Leo Deng <[email protected]>

---------

Signed-off-by: Leo Deng <[email protected]>
Signed-off-by: Leo Deng <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Willie Hung <[email protected]>
@joshuarrrr joshuarrrr added v2.12.0 and removed v2.11.0 labels Oct 5, 2023
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 7, 2023
* removed ftr test step from PR template

Signed-off-by: Leo Deng <[email protected]>

* change changelog

Signed-off-by: Leo Deng <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Leo Deng <[email protected]>

---------

Signed-off-by: Leo Deng <[email protected]>
Signed-off-by: Leo Deng <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
kavilla pushed a commit that referenced this pull request Oct 10, 2023
* removed ftr test step from PR template

Signed-off-by: Leo Deng <[email protected]>

* change changelog

Signed-off-by: Leo Deng <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Leo Deng <[email protected]>

---------

Signed-off-by: Leo Deng <[email protected]>
Signed-off-by: Leo Deng <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 6268794)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ftr test step from PR template
4 participants