[BUG] Fix Discover table panel size auto adjust in Dashboard #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
added
bug
ananzh
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Codecov Report
@@ Coverage Diff @@
## main #5441 +/- ##
=======================================
Coverage 66.82% 66.82%
=======================================
Files 3291 3291
Lines 63174 63174
Branches 10055 10055
=======================================
Hits 42213 42213
- Misses 18479 18483 +4
+ Partials 2482 2478 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ananzh
force-pushed
the
fix-5440-5415
branch
3 times, most recently
from
a10e6f8
to
7bc2815
Compare
ananzh
changed the title
|
There are some flaky cypress tests. Will document here.
This error is because after set 2s as auto refresh interval, the superDatePicker menu panel is closed, which causes the button unable to find. This is not caused by the fix. 
|
* Add React.memo on parent comp * Restore embeddable panel style Issue Resolve opensearch-project#5415 Signed-off-by: ananzh <[email protected]>
AMoo-Miki
reviewed
Nov 8, 2023
AMoo-Miki
reviewed
Nov 8, 2023
src/plugins/discover/public/embeddable/search_embeddable_component.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ananzh <[email protected]>
Co-authored-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]>
AMoo-Miki
approved these changes
Nov 8, 2023
manasvinibs
approved these changes
Nov 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
* [BUG] Fix Discover table panel size auto adjust in Dashboard * Add React.memo on parent comp * Restore embeddable panel style Issue Resolve #5415 Co-authored-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: ananzh <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit e0b6006) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
* [BUG] Fix Discover table panel size auto adjust in Dashboard * Add React.memo on parent comp * Restore embeddable panel style Issue Resolve #5415 Co-authored-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: ananzh <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit e0b6006) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Nov 9, 2023
…5452) * [BUG] Fix Discover table panel size auto adjust in Dashboard * Add React.memo on parent comp * Restore embeddable panel style Issue Resolve #5415 Co-authored-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: ananzh <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit e0b6006) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Nov 9, 2023
…5453) * [BUG] Fix Discover table panel size auto adjust in Dashboard * Add React.memo on parent comp * Restore embeddable panel style Issue Resolve #5415 Co-authored-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: ananzh <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit e0b6006) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#5415
dis-dashboard-bug-fix.mov
Check List
yarn test:jestyarn test:jest_integration