Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] [MD] Able to hide "Local Cluster" option #5904

Merged

Conversation

xinruiba
Copy link
Member

Description

Backport from 26fc902 from #5827

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* [LocalCluster] support in devtool and index pattern creation page

Signed-off-by: Xinrui Bai <[email protected]>

* [LocalCluster] support default cluster in home tutorial page

Signed-off-by: Xinrui Bai <[email protected]>

* [LocalCluster] support default cluster in object import page

Signed-off-by: Xinrui Bai <[email protected]>

---------

Signed-off-by: Xinrui Bai <[email protected]>
(cherry picked from commit 26fc902)
@xinruiba xinruiba changed the title [Manual Backport] 2.x [MD] Able to hide "Local Cluster" option (#5827) [Manual Backport 2.x] [MD] Able to hide "Local Cluster" option (#5827) Feb 20, 2024
@xinruiba xinruiba changed the title [Manual Backport 2.x] [MD] Able to hide "Local Cluster" option (#5827) [Manual Backport 2.x] [MD] Able to hide "Local Cluster" option Feb 20, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
ZilongX
ZilongX previously approved these changes Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6923767) 67.02% compared to head (be0d22a) 67.02%.

Files Patch % Lines
.../plugins/index_pattern_management/public/plugin.ts 0.00% 3 Missing ⚠️
...a/server/search/opensearch_search/decide_client.ts 66.66% 0 Missing and 1 partial ⚠️
...ch/opensearch_search/opensearch_search_strategy.ts 50.00% 1 Missing ⚠️
...c/components/cluster_selector/cluster_selector.tsx 75.00% 0 Missing and 1 partial ⚠️
.../plugins/saved_objects_management/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #5904      +/-   ##
==========================================
- Coverage   67.02%   67.02%   -0.01%     
==========================================
  Files        3302     3302              
  Lines       63601    63610       +9     
  Branches    10143    10147       +4     
==========================================
+ Hits        42628    42634       +6     
+ Misses      18556    18512      -44     
- Partials     2417     2464      +47     
Flag Coverage Δ
Linux_1 35.22% <0.00%> (+<0.01%) ⬆️
Linux_2 55.15% <0.00%> (+<0.01%) ⬆️
Linux_3 43.54% <57.14%> (-0.01%) ⬇️
Linux_4 35.33% <48.00%> (+<0.01%) ⬆️
Windows_1 35.24% <0.00%> (+<0.01%) ⬆️
Windows_2 55.12% <0.00%> (+<0.01%) ⬆️
Windows_3 43.56% <57.14%> (+<0.01%) ⬆️
Windows_4 35.33% <48.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZilongX ZilongX self-requested a review February 20, 2024 22:48
@Flyingliuhub Flyingliuhub merged commit 91d0dea into opensearch-project:2.x Feb 20, 2024
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants