-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Make dashboards management available #6575
[Workspace] Make dashboards management available #6575
Conversation
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
@@ -5,8 +5,9 @@ | |||
"ui": true, | |||
"requiredPlugins": [ | |||
"savedObjects", | |||
"opensearchDashboardsReact" | |||
"opensearchDashboardsReact", | |||
"management" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason move it to requiredPlugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a reference in the code: import { MANAGEMENT_APP_ID } from '../../management/public';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding it as require_bundles is good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If management is not in required bundles, CI will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forget it, it seems requiredBundles has some impact on bundling lifeCycle. Then let's revert to hard-coded version then, sorry for the back-and-forth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a matter, the code has been reverted.
if (category?.id === DEFAULT_APP_CATEGORIES.management.id) { | ||
return filterCondition && id === MANAGEMENT_APP_ID; | ||
} | ||
return filterCondition; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add more comments of why we would like add an exception case for management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the comments has been added.
Signed-off-by: yubonluo <[email protected]>
…earch-Dashboards into main-management-available
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
* [Workspace] Make dashboards management available Signed-off-by: yubonluo <[email protected]> * [Workspace] optimize the code Signed-off-by: yubonluo <[email protected]> * [Workspace] optimize the code Signed-off-by: yubonluo <[email protected]> * [Workspace] modify requiredPlugins Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #6575 created/updated * [Workspace] add more comments Signed-off-by: yubonluo <[email protected]> * [Workspace] delete useless code Signed-off-by: yubonluo <[email protected]> * [Workspace] delete useless code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8db9688) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [Workspace] Make dashboards management available * [Workspace] optimize the code * [Workspace] optimize the code * [Workspace] modify requiredPlugins * Changeset file for PR #6575 created/updated * [Workspace] add more comments * [Workspace] delete useless code * [Workspace] delete useless code --------- (cherry picked from commit 8db9688) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…6575) * [Workspace] Make dashboards management available Signed-off-by: yubonluo <[email protected]> * [Workspace] optimize the code Signed-off-by: yubonluo <[email protected]> * [Workspace] optimize the code Signed-off-by: yubonluo <[email protected]> * [Workspace] modify requiredPlugins Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#6575 created/updated * [Workspace] add more comments Signed-off-by: yubonluo <[email protected]> * [Workspace] delete useless code Signed-off-by: yubonluo <[email protected]> * [Workspace] delete useless code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
User can choose the feature of Dashboards Management when user create/update a workspace.
Issues Resolved
#6574
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration