Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover-next] add query assist to query enhancements plugin #6895

Merged
merged 6 commits into from
Jun 4, 2024
Merged

[Discover-next] add query assist to query enhancements plugin #6895

merged 6 commits into from
Jun 4, 2024

Commits on Jun 4, 2024

  1. add query assist to query enhancements 

    Signed-off-by: Joshua Li <[email protected]>
    @joshuali925
    joshuali925 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1a9d1d9 View commit details
    Browse the repository at this point in the history

  2. align language to uppercase 

    Signed-off-by: Joshua Li <[email protected]>
    @joshuali925
    joshuali925 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0771a0d View commit details
    Browse the repository at this point in the history

  3. pick PR 6167 

    Signed-off-by: Joshua Li <[email protected]>
    @joshuali925
    joshuali925 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    acb0d41 View commit details
    Browse the repository at this point in the history

  4. use useState hooks for query assist 

    There is a bug in data explorer `AppContainer` where memorized
`DiscoverCanvas` gets unmounted after `setQuery`. PR 6167 works around
it by memorizing `AppContainer`. As query assist is no longer being
unmounted, we can use proper hooks to persist state now.

Signed-off-by: Joshua Li <[email protected]>
    @joshuali925
    joshuali925 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    4798c80 View commit details
    Browse the repository at this point in the history

  5. Revert "pick PR 6167" 

    This reverts commit acb0d41.

Wait for official 6167 to merge to avoid conflict

Signed-off-by: Joshua Li <[email protected]>
    @joshuali925
    joshuali925 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    662ee1b View commit details
    Browse the repository at this point in the history

  6. address comments for PR 6894 

    Signed-off-by: Joshua Li <[email protected]>
    @joshuali925
    joshuali925 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9c09135 View commit details
    Browse the repository at this point in the history