[WIP] Async Queries Followup

[sejli]

Description

• Stops index pattern from being created when selecting external datasource
• Checks to see if datasource.name exists before creating dataframe
• Handles PPL error in request

Issues Resolved

#6957

Screenshot

Testing the changes

Changelog

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 6966.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/discover-next@328e08e). Learn more about missing BASE report.

❗ Current head 1b89192 differs from pull request most recent head 471a4ea

Please upload reports for the commit 471a4ea to get more accurate results.

Files	Patch %	Lines
src/plugins/data/server/search/search_service.ts	0.00%	16 Missing ⚠️
src/plugins/data/public/search/search_service.ts	0.00%	8 Missing ⚠️
...on/search/search_source/fetch/get_search_params.ts	0.00%	2 Missing ⚠️
.../data/common/search/search_source/search_source.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##             feature/discover-next    #6966   +/-   ##
========================================================
  Coverage                         ?   66.94%           
========================================================
  Files                            ?     3452           
  Lines                            ?    68331           
  Branches                         ?    11165           
========================================================
  Hits                             ?    45745           
  Misses                           ?    19966           
  Partials                         ?     2620           

Flag	Coverage Δ
Linux_4	34.70% <0.00%> (?)
Windows_1	33.01% <0.00%> (?)
Windows_2	54.88% <0.00%> (?)
Windows_3	44.69% <0.00%> (?)
Windows_4	34.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kavilla]

actually we want to create a dataset without an existing index pattern or not. the problem is that we try to get indiceswhen we create the temp index pattern even tho s3 is availabe

[kavilla]

we want to check the data source if it's like default or not

[sejli]

Don't need to clearCache() here right? Think we cleared it in the public folder

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6966-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c86e90c91e6e61bd610c52a1c11cc88358588560
# Push it to GitHub
git push --set-upstream origin backport/backport-6966-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6966-to-2.x.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6966-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c86e90c91e6e61bd610c52a1c11cc88358588560
# Push it to GitHub
git push --set-upstream origin backport/backport-6966-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6966-to-2.x.

[AMoo-Miki]

This is not to main and should not be backported.