Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove angular related comment and code #7087

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

abbyhu2000
Copy link
Member

Description

Remove angular related comment and code

Changelog

  • fix: Remove angular related comment and code

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (4f54049) to head (8c3de2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7087      +/-   ##
==========================================
- Coverage   67.45%   67.45%   -0.01%     
==========================================
  Files        3448     3448              
  Lines       67916    67916              
  Branches    11042    11042              
==========================================
- Hits        45813    45811       -2     
- Misses      19434    19435       +1     
- Partials     2669     2670       +1     
Flag Coverage Δ
Linux_1 33.07% <ø> (ø)
Linux_2 55.11% <ø> (ø)
Linux_3 45.28% <ø> (+<0.01%) ⬆️
Linux_4 34.86% <ø> (ø)
Windows_1 33.09% <ø> (ø)
Windows_2 55.06% <ø> (ø)
Windows_3 45.28% <ø> (ø)
Windows_4 34.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc merged commit f04708e into opensearch-project:main Jun 21, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 21, 2024
* remove angular related comment and code

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR #7087 created/updated

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f04708e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit to mengweieric/OpenSearch-Dashboards that referenced this pull request Jun 24, 2024
* remove angular related comment and code

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR opensearch-project#7087 created/updated

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jun 25, 2024
* remove angular related comment and code

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR opensearch-project#7087 created/updated

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27 pushed a commit that referenced this pull request Jul 25, 2024
* remove angular related comment and code



* Changeset file for PR #7087 created/updated

---------



(cherry picked from commit f04708e)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 25, 2024
…ensearch-project#7088)

* remove angular related comment and code



* Changeset file for PR opensearch-project#7087 created/updated

---------



(cherry picked from commit f04708e)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants