Rename apm_oss (#37) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bishoy Boktor <[email protected]>
kavilla
approved these changes
Mar 5, 2021
| @@ -69,7 +69,7 @@ export function onPremInstructions({ | |||
| }), | |||
| message: i18n.translate('apmOss.tutorial.apmServer.callOut.message', { | |||
| defaultMessage: `Please make sure your APM Server is updated to 7.0 or higher. \ | |||
| You can also migrate your 6.x data with the migration assistant found in Kibana's management section.`, | |||
| You can also migrate your 6.x data with the migration assistant found in OpenSearch Dashboards's management section.`, | |||
There was a problem hiding this comment.
I can't remember if I did OpenSearch Dashboards's or OpenSearch Dashboards' should we just leave it as Dashboards's
There was a problem hiding this comment.
I've been leaving them as Dashboards's even though Dashboards' is the grammatically correct word. I don't think it matters too much though
mihirsoni
approved these changes
Mar 8, 2021
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
Signed-off-by: Bishoy Boktor <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Bishoy Boktor <[email protected]>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Bishoy Boktor <[email protected]>
raintygao
pushed a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Aug 4, 2023
* feat: remove featureGroup and update management category Signed-off-by: Lin Wang <[email protected]> * feat: filter out empty feature category Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
* feat: remove featureGroup and update management category Signed-off-by: Lin Wang <[email protected]> * feat: filter out empty feature category Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
* feat: remove featureGroup and update management category Signed-off-by: Lin Wang <[email protected]> * feat: filter out empty feature category Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor [email protected]