Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Fix not able to query legacy data when have at least 1 workspace #7254

Merged
merged 9 commits into from
Jul 19, 2024

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Jul 16, 2024

Description

Remove the workspace filter condition when user not in any workspace, the workspace query condition will automatically add when saved objects permission control is enabled.

If saved objects permission control is disabled, there is no need to filter by workspace when no workspace is selected, user should able to see all objects.

Issues Resolved

#7253

Screenshot

Screen.Recording.2024-07-17.at.11.40.35.mov

Testing the changes

  1. Run OSD with workspace and permission enabled
yarn start --no-base-path --workspace.enabled=true --savedObjects.permission.enabled=true
  1. goes to saved objects management page http://localhost:5601/app/management/opensearch-dashboards/objects
  2. user should able to see legacy objects and saved objects associated with workspace.

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jul 16, 2024
@SuZhou-Joe SuZhou-Joe changed the title Fix not able to query legacy data when have at least 1 workspace [workspace] Fix not able to query legacy data when have at least 1 workspace Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (fceba91) to head (eae585c).
Report is 306 commits behind head on main.

Files with missing lines Patch % Lines
...d_objects_management/server/routes/scroll_count.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7254      +/-   ##
==========================================
+ Coverage   67.52%   67.53%   +0.01%     
==========================================
  Files        3504     3504              
  Lines       69410    69412       +2     
  Branches    11324    11324              
==========================================
+ Hits        46868    46877       +9     
+ Misses      19779    19775       -4     
+ Partials     2763     2760       -3     
Flag Coverage Δ
Linux_1 33.15% <0.00%> (ø)
Linux_2 55.46% <ø> (ø)
Linux_3 43.06% <0.00%> (+0.01%) ⬆️
Linux_4 34.76% <77.77%> (?)
Windows_1 33.17% <0.00%> (ø)
Windows_2 55.41% <ø> (ø)
Windows_3 43.06% <0.00%> (ø)
Windows_4 34.76% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am
Copy link
Collaborator Author

✖  core-opensearch-dashboards/opensear      05:49       18       16        1        1        - │
  │    ch-dashboards/apps/data_explorer/di                                                         │
  │    scover_advanced_settings.spec.js         

this is should able to fix by #7252

@ruanyl ruanyl merged commit 3bb4170 into opensearch-project:main Jul 19, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2024
…rkspace (#7254)

* Fix not able to query legacy data when have at least 1 workspace

Signed-off-by: Hailong Cui <[email protected]>

* fix typo

Signed-off-by: Hailong Cui <[email protected]>

* update snapshot

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
(cherry picked from commit 3bb4170)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 20, 2024
…rkspace (#7254) (#7320)

* Fix not able to query legacy data when have at least 1 workspace



* fix typo



* update snapshot



---------



(cherry picked from commit 3bb4170)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x in-next seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Workspace]Not able to view legacy data on saved objects page when workspace exists
4 participants