Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7352

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jul 22, 2024

Backport d30677d from #7346.

Changelog

  • skip

…s while nav group is enabled (#7346)

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305)

* feat: fix the incorrect jumping logic for Index pattern management

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7305 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update with comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update order and remove reset logic

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some category change

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update category

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2c708e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: change the order

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: hide left navigation when workspace enabled

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <[email protected]>
(cherry picked from commit d30677d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry all-star-contributor distinguished-contributor v2.16.0 labels Jul 22, 2024
@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jul 22, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 22, 2024
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.14%. Comparing base (c30287a) to head (1c5e4ef).

Files Patch % Lines
...chrome/ui/header/collapsible_nav_group_enabled.tsx 75.00% 1 Missing and 2 partials ⚠️
.../plugins/index_pattern_management/public/plugin.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7352      +/-   ##
==========================================
- Coverage   68.14%   68.14%   -0.01%     
==========================================
  Files        3470     3470              
  Lines       68712    68718       +6     
  Branches    11197    11198       +1     
==========================================
+ Hits        46821    46825       +4     
- Misses      19154    19155       +1     
- Partials     2737     2738       +1     
Flag Coverage Δ
Linux_1 33.25% <7.69%> (+<0.01%) ⬆️
Linux_2 55.58% <75.00%> (-0.01%) ⬇️
Linux_3 43.14% <9.09%> (-0.02%) ⬇️
Linux_4 34.85% <40.90%> (+0.01%) ⬆️
Windows_1 33.27% <7.69%> (+<0.01%) ⬆️
Windows_2 55.53% <75.00%> (-0.01%) ⬇️
Windows_3 43.16% <9.09%> (-0.01%) ⬇️
Windows_4 34.85% <40.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 5b39ef8 into 2.x Jul 22, 2024
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants