[Worksapce]Add blank check for workspace name #7512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
Hailong-am
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7512 +/- ##
==========================================
- Coverage 63.64% 63.64% -0.01%
==========================================
Files 3629 3629
Lines 79522 79525 +3
Branches 12604 12605 +1
==========================================
+ Hits 50611 50612 +1
- Misses 25842 25844 +2
Partials 3069 3069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
reviewed
Jul 26, 2024
| const workspaceNameSchema = schema.string({ | ||
| validate(value) { | ||
| if (!value || value.trim().length === 0) { | ||
| return "can't be empty or blank."; |
There was a problem hiding this comment.
Not sure if the error message is clear enough for customers to understand what happens here, and from the description of the input, it seems space are valid input though the name can not be pure spaces.
And should we wrap it with i18n?
There was a problem hiding this comment.
field name will prepend to actual message, the whole error message will be
{
"statusCode": 400,
"error": "Bad Request",
"message": "[request body.attributes.name]: can't be empty or blank."
}And should we wrap it with i18n?
as the default validation message of schema.string()haven't been wrapped by i18n. i think we can keep it same
ruanyl
approved these changes
Jul 30, 2024
SuZhou-Joe
approved these changes
Aug 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* add workspace blank check Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #7512 created/updated * add integ test Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #7512 created/updated --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b5f4942) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 9, 2024
* add workspace blank check * Changeset file for PR #7512 created/updated * add integ test * Changeset file for PR #7512 created/updated --------- (cherry picked from commit b5f4942) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add blank or empty check for workspace name
Issues Resolved
#7280
Screenshot
when input a blank workspace name, validation will fail
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration