Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Refactored src/cli_keystore/* #76

Merged
merged 2 commits into from
Mar 13, 2021
Merged

[Rename] Refactored src/cli_keystore/* #76

merged 2 commits into from
Mar 13, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni [email protected]

Issue #, if available: #37

Description of changes: [Rename] Refactored src/cli_keystore/*

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

src/cli_keystore/get_keystore.js Outdated Show resolved Hide resolved
src/cli_keystore/get_keystore.js Outdated Show resolved Hide resolved
src/cli_keystore/get_keystore.test.js Outdated Show resolved Hide resolved
src/cli_keystore/create.test.js Outdated Show resolved Hide resolved
src/cli_keystore/get_keystore.js Outdated Show resolved Hide resolved
@kavilla kavilla self-requested a review March 12, 2021 19:02
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit cacebe6 into opensearch-project:dashboards Mar 13, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] Refactored src/cli_keystore/*

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <[email protected]>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/cli_keystore/*

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <[email protected]>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/cli_keystore/*

Signed-off-by: Mihir Soni <[email protected]>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Aug 11, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 27, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 27, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 9, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 9, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>

add unit test

Signed-off-by: Hailong Cui <[email protected]>

remove permissions

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 13, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>

add unit test

Signed-off-by: Hailong Cui <[email protected]>

remove permissions

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 17, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>

add unit test

Signed-off-by: Hailong Cui <[email protected]>

remove permissions

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 18, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>

add unit test

Signed-off-by: Hailong Cui <[email protected]>

remove permissions

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 19, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>

add unit test

Signed-off-by: Hailong Cui <[email protected]>

remove permissions

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 27, 2023
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>

add unit test

Signed-off-by: Hailong Cui <[email protected]>

remove permissions

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Feb 27, 2024
* add workspace filter into saved objects page

Signed-off-by: Hailong Cui <[email protected]>

* workspace filter

Signed-off-by: Hailong Cui <[email protected]>

* managment workspace filter

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <[email protected]>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <[email protected]>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <[email protected]>

* variable name change and more UTs

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

filters

Signed-off-by: Hailong Cui <[email protected]>

remove copy related

Signed-off-by: Hailong Cui <[email protected]>

revert index pattern chagne

Signed-off-by: Hailong Cui <[email protected]>

add unit test

Signed-off-by: Hailong Cui <[email protected]>

remove permissions

Signed-off-by: Hailong Cui <[email protected]>

pick up workspaceEnabled changes

Signed-off-by: Hailong Cui <[email protected]>

Use formatUrlWithWorkspaceId to foramt inAppURL for saved objects page

Signed-off-by: Hailong Cui <[email protected]>

fix unit test

Signed-off-by: Hailong Cui <[email protected]>

Remove workspacesEnabledSubscription

Signed-off-by: Hailong Cui <[email protected]>

Add unit test

Signed-off-by: Hailong Cui <[email protected]>

Add unit test

Signed-off-by: Hailong Cui <[email protected]>

address review comments

Signed-off-by: Hailong Cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants