[Manual backport 2.x] Introduce the redesign page and applications headers behind a switch (#7637) #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#7637) * Bump OUI to 1.9.0 Signed-off-by: Miki <[email protected]> * Introduce the redesigned page header Signed-off-by: Miki <[email protected]> Update UX of breadcrumbs, menu toggle, and the new contribution points Signed-off-by: Miki <[email protected]> Add renderElement option in HeaderControls Signed-off-by: Shenoy Pratik <[email protected]> Update application mocks and rearrange header layout Signed-off-by: Shenoy Pratik <[email protected]> Break and restyle breadcrumb Signed-off-by: Zhongnan Su <[email protected]> Implement header updates Signed-off-by: Miki <[email protected]> * Introduce HeaderVariant Signed-off-by: Miki <[email protected]> * Organize Header's layout Signed-off-by: Miki <[email protected]> * Fix header control spacing Signed-off-by: Miki <[email protected]> * Conditionally append breadcrumb to recent popover Fix mock for recent items Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Update top nav render and add app header Use ScreenTitle instead of appname from topnav menu Signed-off-by: Shenoy Pratik <[email protected]> * Compress QueryStringInput appearance Signed-off-by: Miki <[email protected]> * Update header for applications Signed-off-by: Miki <[email protected]> * Eliminate colors from the borders of grouped action menu items Signed-off-by: Miki <[email protected]> * Update TopNavControl*Data type to controlType for consistency Signed-off-by: Miki <[email protected]> * Add tests for chrome Header Signed-off-by: Shenoy Pratik <[email protected]> * Update Breadcrumbs tests Signed-off-by: Shenoy Pratik <[email protected]> * Add tests for HeaderControlsContainer Signed-off-by: Miki <[email protected]> * Add tests for TopNavControls and TopNavControlItem Signed-off-by: Shenoy Pratik <[email protected]> * Updated tests for TopNavMenu and TopNavMenuItem Signed-off-by: Shenoy Pratik <[email protected]> * Fix `uiSettingsServiceMock` missing `start` Signed-off-by: Miki <[email protected]> * Add the `target` property to TopNavControlItem Signed-off-by: Miki <[email protected]> * Update Navigation mock and start contract Signed-off-by: Miki <[email protected]> * Add createGetterSetter mock in dashboards app state Signed-off-by: Shenoy Pratik <[email protected]> * Add tests for setting and unsetting header variant Signed-off-by: Miki <[email protected]> * Add tests for setting header controls Signed-off-by: Miki <[email protected]> * Re-skin DataSource selection's trigger button Signed-off-by: Miki <[email protected]> * Conditionally change where theme management menu item shows up Signed-off-by: Miki <[email protected]> * Conditionally change where the help menu items shows up Signed-off-by: Miki <[email protected]> * Make IndexPatternTable page conditionally use the new page header Signed-off-by: Miki <[email protected]> * Make Discover conditionally use the new application header Signed-off-by: Miki <[email protected]> * Make Dashboards conditionally use the new application header Signed-off-by: Miki <[email protected]> * Add changelog fragment Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Miki <[email protected]> * Add tracking issue for empty label for DataSourceMenuPopoverButton Signed-off-by: Miki <[email protected]> * Use EUI aliases in CSS variables Signed-off-by: Miki <[email protected]> * Remove TopNavMenuLink Signed-off-by: Miki <[email protected]> * Make sure OuiHeader doesn't contribute to the background Also: * Remove unused code Signed-off-by: Miki <[email protected]> * Better border hiding for DSM popover button Signed-off-by: Miki <[email protected]> * Make popover button overflow later Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> (cherry picked from commit 265a176) Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
AMoo-Miki
changed the title
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7692 +/- ##
==========================================
+ Coverage 63.79% 63.83% +0.03%
==========================================
Files 3634 3637 +3
Lines 80209 80464 +255
Branches 12703 12777 +74
==========================================
+ Hits 51171 51364 +193
- Misses 25933 25973 +40
- Partials 3105 3127 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Aug 13, 2024
|
CI result looks good to me and we'd better merge this huge backport PR as soon as possible. |
LDrago27
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked commit 265a176 from #7637
Check List
yarn test:jestyarn test:jest_integration