[WorkSpace] Refractor homepage assets list section #7702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7702 +/- ##
==========================================
+ Coverage 63.73% 63.74% +0.01%
==========================================
Files 3637 3637
Lines 80444 80448 +4
Branches 12792 12792
==========================================
+ Hits 51270 51285 +15
+ Misses 26040 26029 -11
Partials 3134 3134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raintygao
reviewed
Aug 14, 2024
src/plugins/saved_objects_management/public/management_section/recent_work.tsx
Outdated
Show resolved
Hide resolved
src/plugins/saved_objects_management/public/management_section/recent_work.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
SuZhou-Joe
force-pushed
the
feat_dashboard_assets
branch
from
5227f37
to
ca37389
Compare
SuZhou-Joe
reviewed
Aug 14, 2024
Comment on lines
+118
to
+121
| const capitalTheFirstLetter = function (recentAccessItem: DetailedRecentlyAccessedItem) { | ||
| return recentAccessItem.type.charAt(0).toUpperCase() + recentAccessItem.type.slice(1); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Nit: seems like an util function, better to move it out of the Component render function.
|
Nice, looks much better. |
Qxisylolo
changed the title
ruanyl
approved these changes
Aug 14, 2024
SuZhou-Joe
approved these changes
Aug 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
* refractor assets section Signed-off-by: Qxisylolo <[email protected]> * refractor assets section Signed-off-by: Qxisylolo <[email protected]> * refractor assets section_1 Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #7702 created/updated * add new test Signed-off-by: Qxisylolo <[email protected]> * delete border Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 765527a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 15, 2024
* refractor assets section * refractor assets section * refractor assets section_1 * Changeset file for PR #7702 created/updated * add new test * delete border --------- (cherry picked from commit 765527a) Signed-off-by: Qxisylolo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pr, I refractor the assets list in the homepage.
Screenshot
empty state
Look
filtering
Title tooltip
Changelog
Check List
yarn test:jestyarn test:jest_integration