De-Couple Dashboards linux building process #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: opensearch-project#473 Signed-off-by: Anan Zhuang <[email protected]>
|
✅ DCO Check Passed 86f4c71 |
kavilla
reviewed
Sep 13, 2021
|
test result: |
kavilla
reviewed
Sep 13, 2021
tmarkley
reviewed
Sep 13, 2021
kavilla
reviewed
Sep 13, 2021
kavilla
reviewed
Sep 13, 2021
kavilla
reviewed
Sep 13, 2021
Signed-off-by: AnanZ <[email protected]>
|
✅ DCO Check Passed 8236123 |
tmarkley
reviewed
Sep 16, 2021
boktorbb
previously approved these changes
Sep 20, 2021
|
Looks awesome! Wording fix. Then I'm wondering what documentation can be updated / created. |
I add some wording to DEVELOPER_GUIDE.md. Should we add more to some places? like open some issues in document repo? |
Thanks bishoy. I will fix the word to 'artifacts' |
Signed-off-by: AnanZ <[email protected]>
|
✅ DCO Check Passed 0255f27 |
kavilla
approved these changes
Sep 21, 2021
tmarkley
approved these changes
Sep 21, 2021
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Sep 21, 2021
When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: opensearch-project#473 Backport PR: opensearch-project#795 Signed-off-by: Anan Zhuang <[email protected]> support multiple CLI options and fix comments Signed-off-by: AnanZ <[email protected]> fix wording to artifacts Signed-off-by: AnanZ <[email protected]>
5 tasks
ananzh
added a commit
that referenced
this pull request
Sep 21, 2021
When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: #473 Backport PR: #795 Signed-off-by: Anan Zhuang <[email protected]> support multiple CLI options and fix comments Signed-off-by: AnanZ <[email protected]> fix wording to artifacts Signed-off-by: AnanZ <[email protected]> Co-authored-by: Ubuntu <[email protected]>
|
This will let us fix opensearch-project/opensearch-build#592. Is it too late to backport to 1.1? (Not strictly necessary but would avoid having to duplicate the custom build script for now). @kavilla |
1 task
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (opensearch-project#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: opensearch-project#836 Signed-off-by: Anan Zhuang <[email protected]>
5 tasks
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2021
When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: opensearch-project#473 backport PR: opensearch-project#795 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2021
When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: opensearch-project#473 backport PR: opensearch-project#795 Signed-off-by: Anan Zhuang <[email protected]>
5 tasks
ananzh
added a commit
that referenced
this pull request
Oct 5, 2021
When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: #473 backport PR: #795 Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Ubuntu <[email protected]>
ananzh
added a commit
that referenced
this pull request
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: #836 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (opensearch-project#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: opensearch-project#836 Backport PR: opensearch-project#840 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (opensearch-project#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: opensearch-project#836 Backport PR: opensearch-project#840 Signed-off-by: Anan Zhuang <[email protected]>
This was referenced Oct 5, 2021
ananzh
added a commit
that referenced
this pull request
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: #836 Backport PR: #840 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
that referenced
this pull request
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: #836 Backport PR: #840 Signed-off-by: Anan Zhuang <[email protected]>
Merged
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0 1.0
# Navigate to the new working tree
cd .worktrees/backport-1.0
# Create a new branch
git switch --create backport/backport-795-to-1.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 799cab44b68d5e841530296268e43a93a7fc1fdc
# Push it to GitHub
git push --set-upstream origin backport/backport-795-to-1.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0Then, create a pull request where the |
kavilla
pushed a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Sep 13, 2022
* De-Couple Dashboards linux building process When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: opensearch-project#473 Signed-off-by: Anan Zhuang <[email protected]> * support multiple CLI options and fix comments Signed-off-by: AnanZ <[email protected]> * fix wording to artifacts Signed-off-by: AnanZ <[email protected]> Co-authored-by: Ubuntu <[email protected]>
Flyingliuhub
pushed a commit
that referenced
this pull request
Sep 13, 2022
* De-Couple Dashboards linux building process When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: #473 Signed-off-by: Anan Zhuang <[email protected]> * support multiple CLI options and fix comments Signed-off-by: AnanZ <[email protected]> * fix wording to artifacts Signed-off-by: AnanZ <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Anan <[email protected]> Co-authored-by: Ubuntu <[email protected]>
Flyingliuhub
added a commit
that referenced
this pull request
Sep 13, 2022
* De-Couple Dashboards linux building process When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: #473 Signed-off-by: Anan Zhuang <[email protected]> * support multiple CLI options and fix comments Signed-off-by: AnanZ <[email protected]> * fix wording to artifacts Signed-off-by: AnanZ <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Anan <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Anan <[email protected]> Co-authored-by: Ubuntu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running yarn build --skip-os-packages it will build 4 tarballs
for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to
do so.
In this PR, we break the building process to allow single linux to
build. If run
yarn build-platform --linux-x64only linux x64 tarballis created. Same for linux arm64 and darwin x64. You could run
yarn build-platform --linux-arm64andyarn build-platform darwin-x64.Partially Resolved:
#473
Signed-off-by: Anan Zhuang [email protected]
Check List