-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose method to register search strategy routes in query enhancement #8245
Expose method to register search strategy routes in query enhancement #8245
Conversation
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8245 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 3743 3743
Lines 88833 88833
Branches 13852 13852
=======================================
+ Hits 56979 56980 +1
+ Misses 31239 31238 -1
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
96b3ccc
to
dc34749
Compare
We merged #8226. Can you rebase on top of the latest changes in main? |
513b764
to
dc34749
Compare
Signed-off-by: Amardeepsingh Siglani <[email protected]>
dc34749
to
4b96e3c
Compare
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
…ery enhancement (#8282) * exposed method to register search strategy routes Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR #8245 created/updated * addressed comment Signed-off-by: Amardeepsingh Siglani <[email protected]> * fix linter error Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8245-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f6924a73d0c1ba257e9febfd650bd1f93350401f
# Push it to GitHub
git push --set-upstream origin backport/backport-8245-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8245-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f6924a73d0c1ba257e9febfd650bd1f93350401f
# Push it to GitHub
git push --set-upstream origin backport/backport-8245-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17 Then, create a pull request where the |
Description
If a new search strategy is registered, we need a way to setup its routes for the search interceptor to call. This PR exposes a setup method to be able to define the routes for the provided strategy
Changelog
Check List
yarn test:jest
yarn test:jest_integration