[Backport 2.x] [Workspace] Integrate workspace front end with data connection type saved object #8269
+485
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…aved object (#8013) * feat: integrate workspace with data connections Signed-off-by: tygao <[email protected]> * update workspace pages and hooks to integrate with data connection Signed-off-by: tygao <[email protected]> * Changeset file for PR #8013 created/updated * remove extra comments Signed-off-by: tygao <[email protected]> * update data source import Signed-off-by: tygao <[email protected]> * test: update tests Signed-off-by: tygao <[email protected]> * Changeset file for PR #8013 created/updated * unify connection type icon and connectionType Signed-off-by: tygao <[email protected]> * test: add tests Signed-off-by: tygao <[email protected]> * display text directly instead of link for data connection in table Signed-off-by: tygao <[email protected]> * Apply suggestions from code review Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Tianyu Gao <[email protected]> * update Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Signed-off-by: Tianyu Gao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit c894584) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8269 +/- ##
==========================================
+ Coverage 64.14% 64.15% +0.01%
==========================================
Files 3740 3740
Lines 88674 88694 +20
Branches 13806 13812 +6
==========================================
+ Hits 56877 56904 +27
+ Misses 31186 31179 -7
Partials 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Sep 20, 2024
ruanyl
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c894584 from #8013.