Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation]feat: remember state when expand / collapse left nav #8286

Merged
merged 4 commits into from
Sep 30, 2024
Merged

[navigation]feat: remember state when expand / collapse left nav #8286

merged 4 commits into from
Sep 30, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Sep 23, 2024 •
edited
Loading

Description

When new left nav is enabled, we should remember the state of the left nav.

Issues Resolved

Screenshot

20240923150000982.mp4

Testing the changes

Changelog

  • feat: [navigation] remember state when expand / collapse left nav

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 23, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8286 created/updated
3c8d5ef
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (d3b776d) to head (f3bb650).
Report is 172 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8286   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        3743     3743           
  Lines       88843    88848    +5     
  Branches    13855    13857    +2     
=======================================
+ Hits        56987    56991    +4     
- Misses      31241    31242    +1     
  Partials      615      615
Flag Coverage Δ
Linux_1 30.06% <0.00%> (-0.01%) ⬇️
Linux_2 58.87% <100.00%> (+<0.01%) ⬆️
Linux_3 40.35% <0.00%> (-0.01%) ⬇️
Linux_4 31.57% <0.00%> (-0.01%) ⬇️
Windows_1 30.07% <0.00%> (-0.01%) ⬇️
Windows_2 58.82% <100.00%> (+<0.01%) ⬆️
Windows_3 40.35% <0.00%> (-0.01%) ⬇️
Windows_4 31.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@opensearch-changeset-bot @SuZhou-Joe
Changeset file for PR opensearch-project#8286 created/updated
b957025
ruanyl
ruanyl previously approved these changes Sep 24, 2024
View reviewed changes
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@opensearch-changeset-bot @SuZhou-Joe
Changeset file for PR opensearch-project#8286 created/updated
d87ccfb
ZilongX
ZilongX previously approved these changes Sep 24, 2024
View reviewed changes
@SuZhou-Joe SuZhou-Joe dismissed stale reviews from ZilongX and ruanyl via b546295 September 25, 2024 02:10
@ZilongX ZilongX self-requested a review September 30, 2024 16:45
@SuZhou-Joe SuZhou-Joe merged commit a663a84 into opensearch-project:main Sep 30, 2024
68 of 69 checks passed
@SuZhou-Joe SuZhou-Joe removed the 2.17.1 label Sep 30, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2024
@github-actions @opensearch-changeset-bot
[navigation]feat: remember state when expand / collapse left nav (#8286)
c5efc1f 
* feat: remember state

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #8286 created/updated

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit a663a84)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 30, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Oct 1, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[navigation]feat: remember state when expand / collapse left nav (#8286…
ea5f614 
…) (#8389)

* feat: remember state



* Changeset file for PR #8286 created/updated

* feat: optimize code



* feat: update



---------



(cherry picked from commit a663a84)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @SuZhou-Joe
[navigation]feat: remember state when expand / collapse left nav (ope…
4460a3a 
…nsearch-project#8286) (opensearch-project#8389)

* feat: remember state



* Changeset file for PR opensearch-project#8286 created/updated

* feat: optimize code



* feat: update



---------



(cherry picked from commit a663a84)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZilongX ZilongX ZilongX approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor navigation v2.18.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @ruanyl @ZilongX