-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Address UI issues of index patterns #8287
Open
Kapian1234
wants to merge
9
commits into
opensearch-project:main
Choose a base branch
from
Kapian1234:workspace_index_patterns_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Workspace] Address UI issues of index patterns #8287
Kapian1234
wants to merge
9
commits into
opensearch-project:main
from
Kapian1234:workspace_index_patterns_fix
+34
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <[email protected]>
…ot bold Signed-off-by: Kapian1234 <[email protected]>
…ot bold Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
…e-filters panel Signed-off-by: Kapian1234 <[email protected]>
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
September 23, 2024 07:55
Kapian1234
requested review from
sejli,
joshuali925 and
huyaboo
as code owners
September 23, 2024 07:55
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8287 +/- ##
==========================================
+ Coverage 64.05% 64.14% +0.08%
==========================================
Files 3741 3743 +2
Lines 88683 88833 +150
Branches 13817 13852 +35
==========================================
+ Hits 56809 56980 +171
+ Misses 31262 31238 -24
- Partials 612 615 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kapian1234 <[email protected]>
…OpenSearch-Dashboards into workspace_index_patterns_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust the padding of index-pattern list panel to 16px.
Make the Pattern column bold, and the Data-source-connection column not bold
Ajust the spacing within the index-pattern detail panel to 16px
Add plusInCircle icon to the Add-scripted-field button
Ajust the space between the search bar and the button to 8px at Source-filters panel
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration