Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Address UI issues of index patterns #8287

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Kapian1234
Copy link
Contributor

@Kapian1234 Kapian1234 commented Sep 23, 2024

Description

Adjust the padding of index-pattern list panel to 16px.
Make the Pattern column bold, and the Data-source-connection column not bold
Ajust the spacing within the index-pattern detail panel to 16px
Add plusInCircle icon to the Add-scripted-field button
Ajust the space between the search bar and the button to 8px at Source-filters panel

Issues Resolved

Screenshot

Screenshot 2024-09-23 at 15 50 02 Screenshot 2024-09-23 at 15 50 35 Screenshot 2024-09-23 at 15 50 46 Screenshot 2024-09-23 at 15 51 07

Testing the changes

Changelog

  • fix: Address UI issues of index patterns

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (636f399) to head (e6d5d66).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8287      +/-   ##
==========================================
+ Coverage   64.05%   64.14%   +0.08%     
==========================================
  Files        3741     3743       +2     
  Lines       88683    88833     +150     
  Branches    13817    13852      +35     
==========================================
+ Hits        56809    56980     +171     
+ Misses      31262    31238      -24     
- Partials      612      615       +3     
Flag Coverage Δ
Linux_1 30.07% <ø> (+0.01%) ⬆️
Linux_2 58.86% <ø> (+<0.01%) ⬆️
Linux_3 40.36% <ø> (?)
Linux_4 31.58% <ø> (+0.14%) ⬆️
Windows_1 30.08% <ø> (+0.01%) ⬆️
Windows_2 58.81% <ø> (+<0.01%) ⬆️
Windows_3 40.36% <ø> (+0.01%) ⬆️
Windows_4 31.58% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kapian1234 <[email protected]>
…OpenSearch-Dashboards into workspace_index_patterns_fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant