Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation]fix: add xxl and xxxl for left nav responsiveness #8289

Merged
merged 3 commits into from
Sep 24, 2024
Merged

[navigation]fix: add xxl and xxxl for left nav responsiveness #8289

merged 3 commits into from
Sep 24, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Sep 23, 2024 •
edited
Loading

Description

OUI v13.0 introduces xxl and xxxl, and it breaks the behavior of responsiveness break points when the screen is larger than 1679px. Comply 2 components with the new introduced hideFor classes to fix the issue.

Issues Resolved

Screenshot

Before the fix

nav.mov

After the fix

image

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe
fix: add xxl and xxxl
80b9951 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe added bug Something isn't working OUI Issues that require migration to OUI navigation 2.17.1 and removed distinguished-contributor labels Sep 23, 2024
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 23, 2024
Hailong-am
Hailong-am approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (f6924a7) to head (a09c1ca).
Report is 90 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8289   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        3743     3743           
  Lines       88833    88833           
  Branches    13852    13852           
=======================================
+ Hits        56979    56980    +1     
+ Misses      31239    31238    -1     
  Partials      615      615
Flag Coverage Δ
Linux_1 30.07% <ø> (ø)
Linux_2 58.86% <ø> (ø)
Linux_3 40.36% <ø> (?)
Linux_4 31.58% <ø> (ø)
Windows_1 30.08% <ø> (ø)
Windows_2 58.81% <ø> (ø)
Windows_3 40.36% <ø> (ø)
Windows_4 31.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
feat: update
88389b2 
Signed-off-by: SuZhou-Joe <[email protected]>
@virajsanghvi
Copy link
Collaborator

snapshot test needs to be updated for header

@SuZhou-Joe
feat: update snapshot
a09c1ca 
Signed-off-by: SuZhou-Joe <[email protected]>
@virajsanghvi virajsanghvi merged commit 6fd284f into opensearch-project:main Sep 24, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
@github-actions
[navigation]fix: add xxl and xxxl for left nav responsiveness (#8289)
c445815 
* fix: add xxl and xxxl

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 6fd284f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 24, 2024
Merged
virajsanghvi pushed a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@SuZhou-Joe @virajsanghvi
[navigation]fix: add xxl and xxxl for left nav responsiveness (opense…
571a35d 
…arch-project#8289)

* fix: add xxl and xxxl

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
@virajsanghvi virajsanghvi mentioned this pull request Sep 24, 2024
Merged
7 tasks
ruanyl pushed a commit that referenced this pull request Sep 25, 2024
@opensearch-trigger-bot @github-actions
[navigation]fix: add xxl and xxxl for left nav responsiveness (#8289) (…
a2f4e6b 
…#8319)

* fix: add xxl and xxxl



* feat: update



* feat: update snapshot



---------


(cherry picked from commit 6fd284f)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Sep 25, 2024
@opensearch-trigger-bot @github-actions @yubonluo
[navigation]fix: add xxl and xxxl for left nav responsiveness (opense…
4cae56a 
…arch-project#8289) (opensearch-project#8319)

* fix: add xxl and xxxl



* feat: update



* feat: update snapshot



---------


(cherry picked from commit 6fd284f)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@virajsanghvi virajsanghvi added look & feel Look and Feel Improvements and removed look & feel Look and Feel Improvements labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.x bug Something isn't working in-next navigation OUI Issues that require migration to OUI Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuZhou-Joe @virajsanghvi @ruanyl @Hailong-am @AMoo-Miki