Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample data page UI when useUpdatedUX enabled #8291

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Sep 23, 2024

Description

This PR is for updating the sample data page UI when useUpdatedUX enabled. It mainly includes below changes:

  • Move data source selector to the top right to align with other pages
  • Remove duplicate sample data title

Issues Resolved

#8312

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version ignore
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user and enter a specific workspace
  • Click "Sample data" in the left navigation
  • The UI should be the same with above screenshot

Changelog

  • feat: Update sample data page UI when useUpdatedUX enabled

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.14%. Comparing base (59200d0) to head (c732708).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/home/public/plugin.ts 0.00% 4 Missing ⚠️
...ublic/application/components/tutorial_directory.js 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8291   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        3743     3743           
  Lines       88833    88846   +13     
  Branches    13852    13852           
=======================================
+ Hits        56979    56992   +13     
  Misses      31239    31239           
  Partials      615      615           
Flag Coverage Δ
Linux_1 30.07% <0.00%> (ø)
Linux_2 58.86% <ø> (ø)
Linux_3 40.36% <0.00%> (ø)
Linux_4 31.60% <78.26%> (+0.01%) ⬆️
Windows_1 30.08% <0.00%> (ø)
Windows_2 58.81% <ø> (ø)
Windows_3 40.36% <0.00%> (+<0.01%) ⬆️
Windows_4 31.60% <78.26%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +174 to +182
return await renderApp(
params.element,
{
...coreStart,
navigation,
setHeaderActionMenu: params.setHeaderActionMenu,
},
params.history
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this change for home page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants