-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample data page UI when useUpdatedUX enabled #8291
base: main
Are you sure you want to change the base?
Update sample data page UI when useUpdatedUX enabled #8291
Conversation
Signed-off-by: Lin Wang <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8291 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 3743 3743
Lines 88833 88846 +13
Branches 13852 13852
=======================================
+ Hits 56979 56992 +13
Misses 31239 31239
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <[email protected]>
return await renderApp( | ||
params.element, | ||
{ | ||
...coreStart, | ||
navigation, | ||
setHeaderActionMenu: params.setHeaderActionMenu, | ||
}, | ||
params.history | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this change for home page?
Description
This PR is for updating the sample data page UI when useUpdatedUX enabled. It mainly includes below changes:
Issues Resolved
#8312
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration