Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page Header]Add responsiveness for application header #8292

Merged

Conversation

zhongnansu
Copy link
Member

Description

[Page Header]Add responsiveness for application header

iShot_2024-09-23_02.08.41.mp4

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (f6924a7) to head (f8db094).
Report is 62 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8292   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        3743     3743           
  Lines       88833    88833           
  Branches    13852    13852           
=======================================
+ Hits        56979    56980    +1     
+ Misses      31239    31238    -1     
  Partials      615      615           
Flag Coverage Δ
Linux_1 30.07% <ø> (ø)
Linux_2 58.86% <ø> (ø)
Linux_3 40.36% <ø> (?)
Linux_4 31.58% <ø> (ø)
Windows_1 30.08% <ø> (ø)
Windows_2 58.81% <ø> (ø)
Windows_3 40.36% <ø> (ø)
Windows_4 31.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu added backport 2.x look & feel Look and Feel Improvements labels Sep 23, 2024
@virajsanghvi
Copy link
Collaborator

I assume other application headers work similarly?

The left padding is a little weird, but given we don't have a design atm, this is good for now.

@zhongnansu
Copy link
Member Author

I assume other application headers work similarly?

The left padding is a little weird, but given we don't have a design atm, this is good for now.

@virajsanghvi There's a width bug of visualzaiton and dashboard, I'll post another PR to fix

@zhongnansu zhongnansu merged commit d47d49c into opensearch-project:main Sep 25, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 25, 2024
(cherry picked from commit d47d49c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8292-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d47d49c981b3d40e278092c1bce7bc42dbc5e160
# Push it to GitHub
git push --set-upstream origin backport/backport-8292-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-8292-to-2.17.

zhongnansu pushed a commit that referenced this pull request Sep 25, 2024
(cherry picked from commit d47d49c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8292-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d47d49c981b3d40e278092c1bce7bc42dbc5e160
# Push it to GitHub
git push --set-upstream origin backport/backport-8292-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-8292-to-2.17.

SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…roject#8292) (opensearch-project#8326)

(cherry picked from commit d47d49c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants