Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] fix breadcrumbs for workspace #8303

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Hailong-am
Copy link
Contributor

@Hailong-am Hailong-am commented Sep 23, 2024

Description

  • prepend workspace name and icon into breadcrumbs
  • remove Home from breadcrumbs
  • workspace overview page title change to Overview
  • Workspace settings page breadcrumbs update

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: [Workspace] prepend workspace name and icon to breadcrumbs

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <[email protected]>
opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 23, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.13%. Comparing base (59200d0) to head (42a8d13).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...onents/workspace_name/workspace_name_with_icon.tsx 75.00% 0 Missing and 1 partial ⚠️
src/plugins/workspace/public/utils.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8303      +/-   ##
==========================================
- Coverage   64.14%   64.13%   -0.01%     
==========================================
  Files        3743     3744       +1     
  Lines       88833    88817      -16     
  Branches    13852    13845       -7     
==========================================
- Hits        56979    56966      -13     
+ Misses      31239    31235       -4     
- Partials      615      616       +1     
Flag Coverage Δ
Linux_1 30.06% <71.42%> (-0.01%) ⬇️
Linux_2 58.85% <100.00%> (-0.01%) ⬇️
Linux_3 40.36% <0.00%> (+<0.01%) ⬆️
Linux_4 31.58% <33.33%> (+<0.01%) ⬆️
Windows_1 30.08% <71.42%> (-0.01%) ⬇️
Windows_2 58.80% <100.00%> (-0.01%) ⬇️
Windows_3 40.36% <0.00%> (+<0.01%) ⬆️
Windows_4 31.58% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hailong Cui <[email protected]>

fix bootstrap error

Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am Hailong-am changed the title [Workspace] prepend workspace name to breadcrumbs [Workspace] fix breadcrumbs for workspace Sep 24, 2024
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am
Copy link
Contributor Author

link checker failure will handled by #8309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant