feat: replace Bluebird usage with native Promise API #8318

hainenber · 2024-09-24T16:16:46Z

Description

Replace Bluebird usage in all @osd packages and own codebase with native Promise API.

Issues Resolved

Screenshot

Testing the changes

All CI should pass

Changelog

feat: replace Bluebird usage with native Promise

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: hainenber <[email protected]>

github-actions · 2024-09-24T16:17:17Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Signed-off-by: hainenber <[email protected]>

github-actions · 2024-09-24T16:33:14Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2024-09-24T16:33:34Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

AMoo-Miki · 2024-10-04T06:47:30Z

packages/osd-opensearch-archiver/src/lib/docs/generate_doc_records_stream.test.ts


 import { createListStream, createPromiseFromStreams, createConcatStream } from '../streams';

 import { createGenerateDocRecordsStream } from './generate_doc_records_stream';
 import { Progress } from '../progress';
 import { createStubStats, createStubClient } from './test_stubs';

+const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:47:59Z

packages/osd-opensearch-archiver/src/lib/docs/index_doc_records_stream.test.ts


 import { createListStream, createPromiseFromStreams } from '../streams';

 import { Progress } from '../progress';
 import { createIndexDocRecordsStream } from './index_doc_records_stream';
 import { createStubStats, createStubClient, createPersonDocRecords } from './test_stubs';
+import { nextTick } from '../../../../../src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:48:09Z

packages/osd-opensearch-archiver/src/lib/streams/map_stream.test.js

 import { createPromiseFromStreams } from './promise_from_streams';
 import { createListStream } from './list_stream';
 import { createMapStream } from './map_stream';
 import { createConcatStream } from './concat_stream';
+import { nextTick } from '../../../../../src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:48:25Z

packages/osd-test/src/functional_test_runner/fixtures/failure_hooks/config.js

@@ -28,7 +28,7 @@
 * under the License.
 */

-import { delay } from 'bluebird';
+import { nextTick } from '../../../../../../src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:48:33Z

src/cli/cluster/cluster.mock.ts

@@ -33,7 +33,7 @@
 // eslint-disable-next-line max-classes-per-file
 import { EventEmitter } from 'events';
 import { assign, random } from 'lodash';
-import { delay } from 'bluebird';
+import { nextTick } from '../../../src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:48:42Z

src/core/server/utils/streams/map_stream.test.ts

 import { createPromiseFromStreams } from './promise_from_streams';
 import { createListStream } from './list_stream';
 import { createMapStream } from './map_stream';
 import { createConcatStream } from './concat_stream';
+import { nextTick } from '../../../../../src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:50:21Z

src/plugins/vis_type_tagcloud/public/components/tag_cloud.test.js

 import { TagCloud } from './tag_cloud';
 import { setHTMLElementOffset, setSVGElementGetBBox } from '../../../../test_utils/public';
+import { nextTick } from '../../../../test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:57:05Z

src/plugins/vis_type_timeline/server/series_functions/worldbank_indicators.js

+      seriesLists.map(function (seriesList) {
+        return seriesList.list[0];
+      })


nit

Suggested change

seriesLists.map(function (seriesList) {

return seriesList.list[0];

})

seriesLists.map(({ list }) => list[0])

Thanks for the nit. I've fixed this in local and push. Would like to commit yours but looks like it'll get flagged as ESLint issue :((

AMoo-Miki · 2024-10-04T06:57:47Z

test/functional/page_objects/common_page.ts

@@ -28,7 +28,7 @@
 * under the License.
 */

-import { delay } from 'bluebird';
+import { nextTick } from 'src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T06:58:01Z

test/functional/page_objects/login_page.ts

@@ -28,7 +28,7 @@
 * under the License.
 */

-import { delay } from 'bluebird';
+import { nextTick } from 'src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T07:04:44Z

test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts

 import { WebElement, WebDriver, By, Key } from 'selenium-webdriver';
 import { PNG } from 'pngjs';
+import { nextTick } from 'src/test_utils/public/helpers';


Let's use timers/promises

Fixed in HEAD. Thanks!

AMoo-Miki · 2024-10-04T07:06:01Z

yarn.lock

@@ -15981,7 +15976,7 @@ string-similarity@^4.0.1:
  resolved "https://registry.yarnpkg.com/string-similarity/-/string-similarity-4.0.4.tgz#42d01ab0b34660ea8a018da8f56a3309bb8b2a5b"
  integrity sha512-/q/8Q4Bl4ZKAPjj8WerIBJWALKkaPRfrvhfF8k/B23i4nzrlRj2/go1m90In7nG/3XDSbOo0+pu6RvCTM9RGMQ==

-"string-width-cjs@npm:string-width@^4.2.0":
+"string-width-cjs@npm:string-width@^4.2.0", string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3:


Can you please undo these unrelated changes?

This was stuck after running yarn, btw

AMoo-Miki

Thanks for this. Please don't mind the repeated texts; they are for my tracking.

codecov · 2024-10-04T07:21:27Z

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (f4f251d) to head (1838a3e).

Files with missing lines	Patch %	Lines
...kages/osd-opensearch-archiver/src/lib/directory.ts	0.00%	1 Missing ⚠️
...ne/server/series_functions/worldbank_indicators.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8318   +/-   ##
=======================================
  Coverage   60.95%   60.96%           
=======================================
  Files        3766     3766           
  Lines       89364    89361    -3     
  Branches    13978    13978           
=======================================
+ Hits        54468    54475    +7     
+ Misses      31498    31488   -10     
  Partials     3398     3398

Flag	Coverage Δ
Linux_1	`28.96% <71.42%> (-0.01%)`	⬇️
Linux_2	`56.30% <33.33%> (+<0.01%)`	⬆️
Linux_3	`37.77% <ø> (?)`
Linux_4	`29.93% <100.00%> (+<0.01%)`	⬆️
Windows_1	`28.98% <71.42%> (-0.01%)`	⬇️
Windows_2	`56.25% <33.33%> (+<0.01%)`	⬆️
Windows_3	`37.77% <ø> (+<0.01%)`	⬆️
Windows_4	`29.93% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: hainenber <[email protected]>

ananzh · 2024-10-30T19:28:22Z

@hainenber thanks for contributing. Could you fix the comment? I currently add this to 2.19. If no progress, we will need to move this to draft then.

hainenber · 2024-11-04T15:08:36Z

hello there, I believe I've addressed the comments as they're now outdated :D

Let me know if there's anything I can do to move the PR forward!

feat: replace Bluebird usage with native Promise

9208d4a

Signed-off-by: hainenber <[email protected]>

github-actions bot added the first-time-contributor label Sep 24, 2024

github-actions bot added the failed changeset label Sep 24, 2024

hainenber and others added 2 commits September 24, 2024 23:18

chore: add CHANGELOG entry

df0ac85

Signed-off-by: hainenber <[email protected]>

Merge branch 'main' into replace-bluebird-with-native-promise

53e09a0

hainenber changed the title ~~feat: replace Bluebird usage with native Promise~~ feat: replace Bluebird usage with native Promise API Sep 24, 2024

AMoo-Miki reviewed Oct 4, 2024

View reviewed changes

AMoo-Miki requested changes Oct 4, 2024

View reviewed changes

hainenber and others added 5 commits October 6, 2024 21:31

Merge branch 'main' into replace-bluebird-with-native-promise

be7b794

chore: replace nextTick with setTimeout in Node-native Timer API

9d5d15b

Signed-off-by: hainenber <[email protected]>

chore: add CHANGELOG fragment

e52de57

Signed-off-by: hainenber <[email protected]>

chore: refactor to FP style

1838a3e

Signed-off-by: hainenber <[email protected]>

Merge branch 'main' into replace-bluebird-with-native-promise

97fc16c

ananzh added the v2.19.0 label Oct 30, 2024

Merge branch 'main' into replace-bluebird-with-native-promise

62f7f5f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace Bluebird usage with native Promise API #8318

feat: replace Bluebird usage with native Promise API #8318

hainenber commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki Oct 4, 2024

hainenber Oct 6, 2024

AMoo-Miki left a comment

codecov bot commented Oct 4, 2024 •

edited

Loading

ananzh commented Oct 30, 2024

hainenber commented Nov 4, 2024

feat: replace Bluebird usage with native Promise API #8318

Are you sure you want to change the base?

feat: replace Bluebird usage with native Promise API #8318

Conversation

hainenber commented Sep 24, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Sep 24, 2024

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Sep 24, 2024

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Sep 24, 2024

❌ Invalid Prefix For Manual Changeset Creation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AMoo-Miki left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

ananzh commented Oct 30, 2024

hainenber commented Nov 4, 2024

hainenber commented Sep 24, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading