-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace]fix the workspace selector jump that occurs when hovering and clicking. #8541
base: main
Are you sure you want to change the base?
[workspace]fix the workspace selector jump that occurs when hovering and clicking. #8541
Conversation
Signed-off-by: Qxisylolo <[email protected]>
src/plugins/workspace/public/components/workspace_selector/workspace_selector.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Qxisylolo <[email protected]>
0f6c3fe
to
26ede1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need confirm whether we need the shadow when hover
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8541 +/- ##
==========================================
+ Coverage 60.93% 60.95% +0.01%
==========================================
Files 3769 3776 +7
Lines 89506 89638 +132
Branches 14012 14045 +33
==========================================
+ Hits 54539 54637 +98
- Misses 31557 31588 +31
- Partials 3410 3413 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This pr fixes the workspace selector jump that occurs when hovering and clicking.
Screenshot
Before:
2024-10-10.13.56.10.mov
After:
2024-10-10.13.56.34.mov
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration