Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Server Side Errors #8562

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

LDrago27
Copy link
Collaborator

Description

Handles internal Server Error that were being thrown.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (9eae148) to head (d75b02e).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/data/server/dql_telemetry/route.ts 0.00% 2 Missing ⚠️
...ver/lib/timeseries_visualization_client_wrapper.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8562      +/-   ##
==========================================
+ Coverage   60.93%   60.96%   +0.02%     
==========================================
  Files        3769     3776       +7     
  Lines       89508    89655     +147     
  Branches    14013    14048      +35     
==========================================
+ Hits        54541    54654     +113     
- Misses      31557    31590      +33     
- Partials     3410     3411       +1     
Flag Coverage Δ
Linux_1 29.12% <40.00%> (+0.11%) ⬆️
Linux_2 56.27% <0.00%> (+0.02%) ⬆️
Linux_3 37.78% <0.00%> (+0.03%) ⬆️
Linux_4 29.95% <0.00%> (+0.03%) ⬆️
Windows_1 29.14% <40.00%> (+0.11%) ⬆️
Windows_2 56.23% <0.00%> (+0.02%) ⬆️
Windows_3 37.79% <0.00%> (+0.03%) ⬆️
Windows_4 29.95% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 force-pushed the secFix branch 4 times, most recently from d1fceaa to 4458935 Compare October 11, 2024 23:14
Signed-off-by: Suchit Sahoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant