[CI] Add tests to github workflow #906
Conversation
Add unit tests to github workflow and also creating a "bad apples" environment variable. Some unit tests just fail on the CI for hardware issues. They should be improved but step one will be calling out the bad apples. Next step will be improving. Also needed to limit the amount of workers because otherwise the hardware can't handle well so then it will accidentally create conflicts. This means we get an accurate test run but it is slower on the CI. Included integration tests which worked out of the box. Included e2e tests as well but it the chrome driver for the application was different from github's chrome so to run it I just upgraded it for the test run. Not ideal, ideally we should probably set up a docker env and install the specific versions since we are now depending on github's virtual env and the dependencies they installed there. But at least this is a first pace. Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
avillk/github_wf
branch
from
32d5ca6
to
96201af
Compare
| - name: Run unit tests | ||
| run: node scripts/jest --ci --colors --maxWorkers=10 | ||
| env: | ||
| SKIP_BAD_APPLES: true |
There was a problem hiding this comment.
Does this mean we will skip some unit tests below for now? Any plan to bring them back?
There was a problem hiding this comment.
only for github actions. locally if this env var is not set it will still run them. the next step would be to 'quarantine' the bad apples and fix them or drop them. more likely to fix them since they work well on good hardware but work bad on bad hardware.
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v1 |
There was a problem hiding this comment.
Is there a particular reason why we're not using v2?
|
|
||
| # github virtual env is the latest chrome | ||
| - name: Setup chromedriver | ||
| run: yarn add --dev chromedriver@latest |
There was a problem hiding this comment.
To clarify, GitHub can only pull the latest? There's no way to specify a particular version?
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] |
There was a problem hiding this comment.
Shouldn't we have this run on all branches? That would catch any potential unexpected merge issues/conflicts.
|
Preferring: #986 over this one for re-run purposes. |
Description
Add unit tests to github workflow and also creating a "bad apples"
environment variable. Some unit tests just fail on the CI for
hardware issues. They should be improved but step one will be
calling out the bad apples. Next step will be improving.
Also needed to limit the amount of workers because otherwise the
hardware can't handle well so then it will accidentally create conflicts.
This means we get an accurate test run but it is slower on the CI.
Included integration tests which worked out of the box.
Included e2e tests as well but it the chrome driver for the application
was different from github's chrome so to run it I just upgraded it for
the test run. Not ideal, ideally we should probably set up a
docker env and install the specific versions since we are now
depending on github's virtual env and the dependencies they installed
there. But at least this is a first pace.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
n/a
Check List