[Rename] Refactored src/core/server/saved_objects directory #91

mihirsoni · 2021-03-07T20:10:34Z

Signed-off-by: Mihir Soni [email protected]

Issue #, if available: #37

Description of changes: Refactored src/core/server/saved_objects directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Mihir Soni <[email protected]>

kavilla

Some accidental renames. Some references to kibana and es. I think a couple file renames missing too.

src/core/server/saved_objects/mappings/lib/get_root_properties_objects.test.ts

src/core/server/saved_objects/mappings/lib/index.ts

src/core/server/saved_objects/mappings/types.ts

src/core/server/saved_objects/migrations/README.md

src/core/server/saved_objects/migrations/core/document_migrator.ts

src/core/server/saved_objects/migrations/core/index_migrator.test.ts

src/core/server/saved_objects/migrations/kibana/__mocks__/kibana_migrator.ts

src/core/server/saved_objects/service/lib/search_dsl/query_params.test.ts

src/core/server/saved_objects/saved_objects_service.ts

kavilla

LGTM thanks!

boktorbb

A couple of small comments

src/core/server/saved_objects/migrations/core/call_cluster.ts

boktorbb · 2021-03-13T00:00:59Z

src/core/server/saved_objects/migrations/index.ts

@@ -18,7 +18,7 @@
 */

 export { MigrationResult } from './core';
-export { KibanaMigrator, IKibanaMigrator } from './kibana';
+export { OpenSearchDashboardsMigrator, IOpenSearchDashboardsMigrator } from './opensearch-dashboards';


This is a file so should be ./opensearch_dashboards, right?

I think it is a directory, so kept it that way.

Signed-off-by: Mihir Soni <[email protected]>

boktorbb

Looks good

* [Rename] Refactored src/core/server/saved_objects directory Signed-off-by: Mihir Soni <[email protected]> * [Rename] Refactored src/core/server/saved_objects directory Signed-off-by: Mihir Soni <[email protected]> * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed PR comments Signed-off-by: Mihir Soni <[email protected]>

* move index pattern to libaray Signed-off-by: Hailong Cui <[email protected]> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>

* move index pattern to libaray Signed-off-by: Hailong Cui <[email protected]> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> index pattern always show under library Signed-off-by: Hailong Cui <[email protected]>

…ement and SavedObject management as standalone app, retire dashboard management (opensearch-project#208) * feat: init retire dashboard management Signed-off-by: tygao <[email protected]> * move index pattern to Library (opensearch-project#91) * move index pattern to libaray Signed-off-by: Hailong Cui <[email protected]> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> index pattern always show under library Signed-off-by: Hailong Cui <[email protected]> * functional test Signed-off-by: Hailong Cui <[email protected]> * feat: move data source / advanced settings / saved objects management out of Dashboard management Signed-off-by: SuZhou-Joe <[email protected]> * feat: update test Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * fix: fix failed overview header ut Signed-off-by: tygao <[email protected]> * fix: deeplink inside saved objects management page Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test fail Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test for each page wrapper Signed-off-by: SuZhou-Joe <[email protected]> * feat: some optimization Signed-off-by: SuZhou-Joe <[email protected]> * remove management dependency Signed-off-by: Hailong Cui <[email protected]> * test: update cypress config to use workspace branch Signed-off-by: tygao <[email protected]> * Replace ManagementAppMountParams with AppMountParameters Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: tygao <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>

[Rename] Refactored src/core/server/saved_objects directory

8e2e42f

Signed-off-by: Mihir Soni <[email protected]>

mihirsoni added >Fork rename labels Mar 7, 2021

mihirsoni requested review from kavilla and boktorbb March 7, 2021 20:10

[Rename] Refactored src/core/server/saved_objects directory

9237512

Signed-off-by: Mihir Soni <[email protected]>

kavilla requested changes Mar 9, 2021

View reviewed changes

kavilla reviewed Mar 10, 2021

View reviewed changes

src/core/server/saved_objects/saved_objects_service.ts Outdated Show resolved Hide resolved

[Rename] addressed review feedbacks

8796134

mihirsoni requested a review from kavilla March 11, 2021 06:40

[Rename] addressed review feedbacks

67ead66

kavilla approved these changes Mar 12, 2021

View reviewed changes

boktorbb reviewed Mar 13, 2021

View reviewed changes

[Rename] addressed PR comments

828bd1b

Signed-off-by: Mihir Soni <[email protected]>

boktorbb approved these changes Mar 13, 2021

View reviewed changes

boktorbb merged commit 2ee9d22 into opensearch-project:dashboards Mar 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Rename] Refactored src/core/server/saved_objects directory #91

[Rename] Refactored src/core/server/saved_objects directory #91

mihirsoni commented Mar 7, 2021

kavilla left a comment

kavilla left a comment

boktorbb left a comment

boktorbb Mar 13, 2021

mihirsoni Mar 13, 2021

boktorbb left a comment

[Rename] Refactored src/core/server/saved_objects directory #91

[Rename] Refactored src/core/server/saved_objects directory #91

Conversation

mihirsoni commented Mar 7, 2021

kavilla left a comment

Choose a reason for hiding this comment

kavilla left a comment

Choose a reason for hiding this comment

boktorbb left a comment

Choose a reason for hiding this comment

boktorbb Mar 13, 2021

Choose a reason for hiding this comment

mihirsoni Mar 13, 2021

Choose a reason for hiding this comment

boktorbb left a comment

Choose a reason for hiding this comment