Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Refactored src/plugins/vis_type_table directory #97

Merged
merged 2 commits into from
Mar 12, 2021
Merged

[Rename] Refactored src/plugins/vis_type_table directory #97

merged 2 commits into from
Mar 12, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni [email protected]

Issue #, if available: #37

Description of changes: Refactored src/plugins/vis_type_table directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but LG

@@ -31,7 +31,7 @@ jest.mock('./table_vis_response_handler', () => ({
describe('interpreter/functions#table', () => {
const fn = functionWrapper(createTableVisFn());
const context = {
type: 'kibana_datatable',
type: 'opensearch_dashboardsdatatable',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think would be opensearch_dashboards_datatable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixd

@@ -39,14 +39,14 @@ interface RenderValue {
}

export const createTableVisFn = (): ExpressionFunctionDefinition<
'kibana_table',
'opensearch_dashboardstable',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe opensearch_dashboards_table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kavilla kavilla self-requested a review March 12, 2021 10:39
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kavilla kavilla merged commit 9e792e6 into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] Refactored src/plugins/vis_type_table directory

Signed-off-by: Mihir Soni <[email protected]>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_table directory

Signed-off-by: Mihir Soni <[email protected]>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_table directory

Signed-off-by: Mihir Soni <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 22, 2023
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants