addressing comments

Signed-off-by: Bharathwaj G <[email protected]>
opensearch-project · Aug 19, 2024 · 1052ead · 1052ead
1 parent c20f12c
commit 1052ead
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java b/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java
@@ -285,7 +285,7 @@ private void addBaseMetrics(MetricStat metricStat, Set<MetricStat> metricSet) {
                 Queue<MetricStat> metricQueue = new LinkedList<>(metricStat.getBaseMetrics());
                 while (metricQueue.isEmpty() == false) {
                     MetricStat metric = metricQueue.poll();
-                    if (metric.isDerivedMetric()) {
+                    if (metric.isDerivedMetric() && !metricSet.contains(metric)) {
                         metricQueue.addAll(metric.getBaseMetrics());
                     }
                     metricSet.add(metric);