Skip to content

Commit

Permalink
Fix getUpdatedCustoms test
Browse files Browse the repository at this point in the history
Signed-off-by: Sooraj Sinha <[email protected]>
  • Loading branch information
soosinha committed Jun 14, 2024
1 parent 0ab67e6 commit 8f3c702
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public DiffableUtils.MapDiff<String, ClusterState.Custom, Map<String, ClusterSta
ClusterState clusterState,
ClusterState previousClusterState,
boolean includeEphemeral,
boolean firstUploadForSplitGlobalMetadata
boolean firstUploadForEphemeralMetadata
) {
if (!includeEphemeral) {
// When includeEphemeral is false, we do not want store any custom objects
Expand All @@ -142,7 +142,7 @@ public DiffableUtils.MapDiff<String, ClusterState.Custom, Map<String, ClusterSta
NonDiffableValueSerializer.getAbstractInstance()
);
}
if (firstUploadForSplitGlobalMetadata) {
if (firstUploadForEphemeralMetadata) {
// For first split global metadata upload, we want to upload all customs
return DiffableUtils.diff(
Collections.emptyMap(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public void testGetUpdatedCustoms() {
CustomMetadata4.TYPE,
new CustomMetadata4("data4"),
CustomMetadata5.TYPE,
new CustomMetadata5("data4")
new CustomMetadata5("data5")
);
ClusterState currentState = ClusterState.builder(new ClusterName("test-cluster"))
.metadata(Metadata.builder().customs(currentCustoms))
Expand Down

0 comments on commit 8f3c702

Please sign in to comment.