Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Constructors Incompatibility of API classes. #14068

Closed
gargharsh3134 opened this issue Jun 7, 2024 · 0 comments · Fixed by #13926 or #14123
Closed

[BUG] Constructors Incompatibility of API classes. #14068

gargharsh3134 opened this issue Jun 7, 2024 · 0 comments · Fixed by #13926 or #14123
Assignees
Labels
bug Something isn't working Cluster Manager

Comments

@gargharsh3134
Copy link
Contributor

Describe the bug

As part of #12333, constructors of some of the classes marked as API were changed to add a new ClusterManagerMetrics parameter. This is causing failures in the respective backport PRs (#13755 for reference) because of breaking changes.

Resolution:
The older constructors can use NoOpMetricsRegistry instance and instantiate the ClusterManagerMetrics object.

Related component

Cluster Manager

To Reproduce

Reference Backport PR (#13755)

Expected behavior

The constructors compatibility for API classes should be retained.

Additional Details

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment