Retaining old constructor of MasterService class to maintain compatib… #14123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility Signed-off-by: Harsh Garg <[email protected]>
shwetathareja
approved these changes
Jun 10, 2024
gargharsh3134
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
sohami,
tlfeng and
VachaShah
as code owners
rajiv-kv
approved these changes
Jun 10, 2024
3 tasks
shwetathareja
merged commit 42d6af6
into
opensearch-project:main
58 of 60 checks passed
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…ility (opensearch-project#14123) Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>
This was referenced Jun 13, 2024
3 tasks
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ility (opensearch-project#14123) Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #12333, constructors of some of the classes marked as API were changed to add a new ClusterManagerMetrics parameter. This was causing failures in the respective backport PRs (#13755 for reference) because of breaking changes. This PR is targeted to retain the old constructor of MasterService class.
Related Issues
Resolves #14068
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.